From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSsxP-0004k5-7o for qemu-devel@nongnu.org; Thu, 28 Jul 2016 17:35:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSsxL-0004sl-21 for qemu-devel@nongnu.org; Thu, 28 Jul 2016 17:35:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSsxK-0004rT-QX for qemu-devel@nongnu.org; Thu, 28 Jul 2016 17:35:02 -0400 References: <1469719485-31366-1-git-send-email-peter.maydell@linaro.org> From: Eric Blake Message-ID: <579A7A84.2000207@redhat.com> Date: Thu, 28 Jul 2016 15:35:00 -0600 MIME-Version: 1.0 In-Reply-To: <1469719485-31366-1-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bbk7lOsvv0v9lSo6ucoEqUaAWrcu0aGlp" Subject: Re: [Qemu-devel] [PATCH] Update ancient copyright string in QEMU -version output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Fabrice Bellard , Stefan Hajnoczi , patches@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bbk7lOsvv0v9lSo6ucoEqUaAWrcu0aGlp From: Eric Blake To: Peter Maydell , qemu-devel@nongnu.org Cc: Fabrice Bellard , Stefan Hajnoczi , patches@linaro.org Message-ID: <579A7A84.2000207@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Update ancient copyright string in QEMU -version output References: <1469719485-31366-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1469719485-31366-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/28/2016 09:24 AM, Peter Maydell wrote: > Currently the -version command line argument prints a string ending > with "Copyright (c) 2003-2008 Fabrice Bellard". This is now some > eight years out of date; abstract it out of the several places that > print the string and update it to: >=20 > Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers= >=20 > to reflect the work by all the QEMU Project contributors over the > last decade. >=20 > Signed-off-by: Peter Maydell > --- > The aim here is to (1) update the dates and (2) acknowledge > the work of all our contributors. I'm open to suggestions > on the exact wording (or on which header file we should > put the #define in...) >=20 > I only pulled out the copyright string proper into the #define > because a GUI About box is going to want just that, with no > leading ',' or trailing newline. >=20 > Fabrice: I have cc'd you since this is proposing an update > to your copyright info. >=20 > bsd-user/main.c | 3 ++- > include/qemu-common.h | 4 ++++ > linux-user/main.c | 2 +- > vl.c | 3 ++- > 4 files changed, 9 insertions(+), 3 deletions(-) >=20 Missing at least qemu-img.c, where the dates started at 2004 instead of 2003. I don't see any particular problem with having ALL qemu utilities report 2003-2016, even if some of them weren't available in 2003, since they DO share a code base with copyrights that far back. It would also be okay in my mind to list JUST 2016 (rather than the range 2003-2016) - that's what utilities like GNU Coreutils do (see 'ls --version') at the recommendation of the GNU Coding Standards (that is, code has ranged copyrights for whenever it was touched, but binaries only need to declare a copyright for the year it was built).0 > diff --git a/include/qemu-common.h b/include/qemu-common.h > index 1f2cb94..9e8b0bd 100644 > --- a/include/qemu-common.h > +++ b/include/qemu-common.h > @@ -18,6 +18,10 @@ > =20 > #include "qemu/option.h" > =20 > +/* Copyright string for -version arguments, About dialogs, etc */ > +#define QEMU_COPYRIGHT "Copyright (c) 2003-2016 " \ > + "Fabrice Bellard and the QEMU Project developers" In general, I'm a definite fan of this approach, since it lets us bump the year in a single file, rather than hunting down every binary that needs an update. Looking forward to v2 that covers the full list. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bbk7lOsvv0v9lSo6ucoEqUaAWrcu0aGlp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXmnqEAAoJEKeha0olJ0NqkF8H/ioC6PEooqy4csnf2JpnsPwq gSwqwFo9AZ2DQOZm1QpzYzbe7ixeoIshp+rKCVlAB5JejRH7XlLovF2WRrH106vv Qqr9rrk+rQfL9aRSTmPUBgdOKA8zuDO6KuxXlffEREENLCorR/4WwItLZHwtRocG 5IY2MoxsWwFnaTkfosNELVZ5YhpV1GqwZDP/2nqez7NbX5MmmpiWnIXECc4I8kaj q1kLot6fTt7960JDqTCUXUnWGmLtu7mmZ9ABAy4bGwS2paMk+Npo1fLYlpfhnH7M vLaZfupzZC/qntTXiTD1tKfykfSnYOK70hLAPTV6Zhoz3wcZuSR/h/JV1mDcJX4= =KD92 -----END PGP SIGNATURE----- --bbk7lOsvv0v9lSo6ucoEqUaAWrcu0aGlp--