From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bStBL-0005uR-Rn for qemu-devel@nongnu.org; Thu, 28 Jul 2016 17:49:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bStBI-0000wx-KS for qemu-devel@nongnu.org; Thu, 28 Jul 2016 17:49:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bStBI-0000wt-Ea for qemu-devel@nongnu.org; Thu, 28 Jul 2016 17:49:28 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CD545883A8 for ; Thu, 28 Jul 2016 21:49:27 +0000 (UTC) References: <20160728143808.13707-1-marcandre.lureau@redhat.com> <20160728143808.13707-20-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <579A7DE7.7060300@redhat.com> Date: Thu, 28 Jul 2016 15:49:27 -0600 MIME-Version: 1.0 In-Reply-To: <20160728143808.13707-20-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="W86vxpFWluJO38NUnWpXSf5Oe2Bru8W4o" Subject: Re: [Qemu-devel] [PATCH v2 19/37] char: disconnect peer when qemu_chr_free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --W86vxpFWluJO38NUnWpXSf5Oe2Bru8W4o From: Eric Blake To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Message-ID: <579A7DE7.7060300@redhat.com> Subject: Re: [PATCH v2 19/37] char: disconnect peer when qemu_chr_free() References: <20160728143808.13707-1-marcandre.lureau@redhat.com> <20160728143808.13707-20-marcandre.lureau@redhat.com> In-Reply-To: <20160728143808.13707-20-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/28/2016 08:37 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > chr_disconnect callback is used to cleanup server socket peer. This > removes some leaks when the chardev is freed. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > qemu-char.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake >=20 > diff --git a/qemu-char.c b/qemu-char.c > index e4b8448..6ed6dd6 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -4031,6 +4031,7 @@ static void qemu_chr_free_common(CharDriverState = *chr) > =20 > void qemu_chr_free(CharDriverState *chr) > { > + qemu_chr_disconnect(chr); > if (chr->chr_close) { > chr->chr_close(chr); > } >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --W86vxpFWluJO38NUnWpXSf5Oe2Bru8W4o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXmn3nAAoJEKeha0olJ0NqcHkH/0J/wnC91opYXxzhYCbrr5qs mEsLfF1mM/97zYip6dBMHmqyB+JQb2T8zD64nQyidUKTcsNeblYF+w8vDJHJrxTL 7BkF5agsSkW15xIQqkz2x+woAMT04ZJgp98uONMcPly9uCWDOd9zA5WmB23mOSOX 2W3xH0icQdiGpPGMUNA/BnSYfzF7RnO5JL48tgVaoouD+naPmxc19UdRsowX1Yhy UIHv/YRVP53ayY+hASMxVImWSHPJq8IQAp68jLXE2fdK4qQ5ZnrPkglMBHuNKxhb DMIy6lXZEPbGDJQoaSOJWM38hizG39pL9eivuHBEe10qYRQ6nI57F/55PGlGV4U= =E5Cw -----END PGP SIGNATURE----- --W86vxpFWluJO38NUnWpXSf5Oe2Bru8W4o--