From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTEiW-0004Ea-6N for qemu-devel@nongnu.org; Fri, 29 Jul 2016 16:49:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTEiT-0003Xh-0K for qemu-devel@nongnu.org; Fri, 29 Jul 2016 16:49:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTEiS-0003XX-OD for qemu-devel@nongnu.org; Fri, 29 Jul 2016 16:49:08 -0400 References: <1469689643-11556-1-git-send-email-saxenap.ltc@gmail.com> <1469689643-11556-2-git-send-email-saxenap.ltc@gmail.com> From: Eric Blake Message-ID: <579BC143.4090203@redhat.com> Date: Fri, 29 Jul 2016 14:49:07 -0600 MIME-Version: 1.0 In-Reply-To: <1469689643-11556-2-git-send-email-saxenap.ltc@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eXUUOlgrrR8mmaFGLVsTBFOP2OKbAQsCg" Subject: Re: [Qemu-devel] [PATCH for-2.7 v5.1 1/2] vhost-user: Introduce a new protocol feature REPLY_ACK. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prerna Saxena , qemu-devel@nongnu.org Cc: Prerna Saxena , anilkumar.boggarapu@nutanix.com, felipe@nutanix.com, marcandre.lureau@gmail.com, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eXUUOlgrrR8mmaFGLVsTBFOP2OKbAQsCg From: Eric Blake To: Prerna Saxena , qemu-devel@nongnu.org Cc: Prerna Saxena , anilkumar.boggarapu@nutanix.com, felipe@nutanix.com, marcandre.lureau@gmail.com, mst@redhat.com Message-ID: <579BC143.4090203@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.7 v5.1 1/2] vhost-user: Introduce a new protocol feature REPLY_ACK. References: <1469689643-11556-1-git-send-email-saxenap.ltc@gmail.com> <1469689643-11556-2-git-send-email-saxenap.ltc@gmail.com> In-Reply-To: <1469689643-11556-2-git-send-email-saxenap.ltc@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/28/2016 01:07 AM, Prerna Saxena wrote: > From: Prerna Saxena >=20 > This introduces the VHOST_USER_PROTOCOL_F_REPLY_ACK. >=20 > + > +With this protocol extension negotiated, the sender (QEMU) can set the= > +"need_reply" [Bit 3] flag to any command. This indicates that > +the client MUST respond with a Payload VhostUserMsg indicating success= or > +failure. The payload should be set to zero on success or non-zero on f= ailure. > +(Unless the message already has an explicit reply body) Rather than make this parenthetical, I would go with: The payload should be set to zero on success or non-zero on failure, unless the message already has an explicit reply body. > + > +This indicates to QEMU that the requested operation has deterministica= lly > +been met or not. Today, QEMU is expected to terminate the main vhost-u= ser Reads awkwardly; maybe: The response payload gives QEMU a deterministic indication of the result of the command. > +loop upon receiving such errors. In future, qemu could be taught to be= more > +resilient for selective requests. > + > +For the message types that already solicit a reply from the client, th= e > +presence of VHOST_USER_PROTOCOL_F_REPLY_ACK or need_reply bit being se= t brings > +no behaviourial change. (See the 'Communication' section for details.)= s/behaviourial/behavioural/ (or if the document widely favors US spelling, behavioral) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eXUUOlgrrR8mmaFGLVsTBFOP2OKbAQsCg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXm8FDAAoJEKeha0olJ0NqUXwH/AjYkZwB6F5Tu3J9MhDK9Pts foLlss0RaGz16UYMlPlAEwlX0HLXBekkya+8yrcbykhj3XqC631ZHIuRaMGkI8nv AeQKdp/jva1yZwOO7uZ/0NBGgWXpIOEnqee6ZHlgGU7aKjnBOZH2dwWcbz2Lxmnh k6CZos4JO2Fqs4cBpKkArlumIeh7wFjlkdFHmGAI6jJss/3v/YhUuTje9HhSAyNs WURBFohrMgV1dcfch+wPNyILLe9qXihB53F2oA+RyMYC50+8+X8voU5w893gQxIx 9ZGIzN77vLM0dKFOOCfQ+5xMv1y6OrH/f0c/GtoGvWYoCGByNis/1EpddPam+rw= =/MMf -----END PGP SIGNATURE----- --eXUUOlgrrR8mmaFGLVsTBFOP2OKbAQsCg--