From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: alex.bennee@linaro.org, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] qemu-iotests: move check-block back to Makefiles
Date: Wed, 2 Sep 2020 10:37:45 +0200 [thread overview]
Message-ID: <579e9d08-6235-0cdc-bbf6-07f2fc489426@redhat.com> (raw)
In-Reply-To: <20200902081933.GE403297@redhat.com>
On 02/09/20 10:19, Daniel P. Berrangé wrote:
> On Wed, Sep 02, 2020 at 04:00:46AM -0400, Paolo Bonzini wrote:
>> check-block has its own test harness, unlike every other test. If
>> we capture its output, as is in general nicer to do without V=1,
>> there will be no sign of progress. So for lack of a better option
>> just move the invocation of the test back to Makefile rules.
>
> I expect the correct long term solution here is to stop using the
> check-block.sh script. Instead have code which sets up each
> of the I/O tests as an explicit test target in meson. We could
> use meson's test grouping features too.
I'm not sure, "check-acceptance" will never be integrated in Meson, and
it may well be the same for "check-block". Actually I wonder if Avocado
would be a better check-block.sh than check-block.sh.
Paolo
next prev parent reply other threads:[~2020-09-02 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 8:00 [PATCH] qemu-iotests: move check-block back to Makefiles Paolo Bonzini
2020-09-02 8:19 ` Daniel P. Berrangé
2020-09-02 8:37 ` Paolo Bonzini [this message]
2020-09-02 10:21 ` Thomas Huth
2020-09-03 15:51 ` Lukáš Doktor
2020-09-02 16:51 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579e9d08-6235-0cdc-bbf6-07f2fc489426@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).