From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUxHO-000768-Ro for qemu-devel@nongnu.org; Wed, 03 Aug 2016 10:36:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUxHJ-0005Ad-2A for qemu-devel@nongnu.org; Wed, 03 Aug 2016 10:36:17 -0400 Received: from smtp.citrix.com ([66.165.176.89]:5879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUxHI-00059B-TT for qemu-devel@nongnu.org; Wed, 03 Aug 2016 10:36:12 -0400 References: <1470146790-6168-1-git-send-email-paulinaszubarczyk@gmail.com> <1470146790-6168-2-git-send-email-paulinaszubarczyk@gmail.com> From: David Vrabel Message-ID: <57A20152.6030607@citrix.com> Date: Wed, 3 Aug 2016 15:36:02 +0100 MIME-Version: 1.0 In-Reply-To: <1470146790-6168-2-git-send-email-paulinaszubarczyk@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v4 1/2] Interface for grant copy operation in libs. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paulina Szubarczyk , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, qemu-devel@nongnu.org, david.vrabel@citrix.com, anthony.perard@citrix.com, roger.pau@citrix.com On 02/08/16 15:06, Paulina Szubarczyk wrote: > > +/** > + * Copy memory from or to grant references. The information of each operations > + * are contained in 'xengnttab_grant_copy_segment_t'. The @flag value indicate > + * the direction of an operation (GNTCOPY_source_gref\GNTCOPY_dest_gref). > + * > + * The sum of fields @offset[i] and @len[i] of 'xengnttab_grant_copy_segment_t' > + * should not exceed XEN_PAGE_SIZE "For each segment, @virt may cross a page boundary but @offset + @len must be less than XEN_PAGE_SIZE." might be better. With or without the above change: Reviewed-by: David Vrabel David