From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Bruce Rogers <brogers@suse.com>, qemu-devel@nongnu.org
Cc: anthony.perard@citrix.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin
Date: Thu, 4 Aug 2016 10:51:57 +0800 [thread overview]
Message-ID: <57A2ADCD.9040402@cn.fujitsu.com> (raw)
In-Reply-To: <579F2FBA020000480012E89B@prv-mh.provo.novell.com>
On 08/02/2016 01:17 AM, Bruce Rogers wrote:
> Hi Cao,
>
>
> Upon re-reading your comment, I believe you are still thinking that
>
> it was right to use the error object in this context. The fact that this
>
> device has no pin interrupt is _not_ an error condition, and hence the
>
> use of error_setg() is not appropriate, and in fact causes Xen HVM PCI
>
> passthrough to fail, when it would otherwise succeed.
>
Hi bruce,
Thanks for pointing it out, I didn't have much knowledge on this topic,
but you words buys me, I am fine with the patch.
>
> This patch does not attempt to address any shortcomings with
>
> XEN_PT_LOG, since it is still in use in many other places in this source
>
> file.
>
>
> hth,
>
>
> Bruce
>
>
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-08-04 2:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 15:30 [Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin Bruce Rogers
2016-07-28 3:10 ` Cao jin
2016-08-01 17:17 ` Bruce Rogers
2016-08-04 2:51 ` Cao jin [this message]
2016-08-04 14:08 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A2ADCD.9040402@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=anthony.perard@citrix.com \
--cc=brogers@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).