From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVKd7-0003nn-9r for qemu-devel@nongnu.org; Thu, 04 Aug 2016 11:32:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVKd3-0002eG-8U for qemu-devel@nongnu.org; Thu, 04 Aug 2016 11:32:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVKd2-0002e5-WE for qemu-devel@nongnu.org; Thu, 04 Aug 2016 11:32:13 -0400 References: <1470309276-5012-1-git-send-email-peter.maydell@linaro.org> From: Eric Blake Message-ID: <57A35FFA.8060003@redhat.com> Date: Thu, 4 Aug 2016 09:32:10 -0600 MIME-Version: 1.0 In-Reply-To: <1470309276-5012-1-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OGbqiiqS6QIR8mgVgS32rEfBFpAdanEc3" Subject: Re: [Qemu-devel] [PATCH v2 for-2.7] Update ancient copyright string in -version output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org, Stefan Hajnoczi , Fabrice Bellard , Anthony Liguori This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OGbqiiqS6QIR8mgVgS32rEfBFpAdanEc3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2016 05:14 AM, Peter Maydell wrote: > Currently the -version command line argument prints a string ending > with "Copyright (c) 2003-2008 Fabrice Bellard". This is now some > eight years out of date; abstract it out of the several places that > print the string and update it to: >=20 > Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers= >=20 > to reflect the work by all the QEMU Project contributors over the > last decade. >=20 > Signed-off-by: Peter Maydell > Acked-by: Stefan Hajnoczi > --- Reviewed-by: Eric Blake > The aim here is to (1) update the dates and (2) acknowledge > the work of all our contributors. I'm open to bikeshedding > on the exact wording (or on which header file we should > put the #define in...) >=20 > I only pulled out the copyright string proper into the #define > because a GUI About box is going to want just that, with no > leading ',' or trailing newline. >=20 > Fabrice: I have cc'd you since this is proposing an update > to your copyright info. >=20 > v1->v2 changes: add the qemu-img.c string. > --- > bsd-user/main.c | 3 ++- > include/qemu-common.h | 4 ++++ > linux-user/main.c | 2 +- > qemu-img.c | 2 +- > vl.c | 3 ++- > 5 files changed, 10 insertions(+), 4 deletions(-) qemu-io has a --version option that probably ought to output copyright information, but as it currently does not do so, this patch need not be the one that tweaks it. qemu-nbd has a --version option, where the copyright info is currently: Copyright (C) 2006 Anthony Liguori . I don't know if we want to rework that one in light of this patch, or if we can just blindly use this code. Anthony? > +/* Copyright string for -version arguments, About dialogs, etc */ > +#define QEMU_COPYRIGHT "Copyright (c) 2003-2016 " \ > + "Fabrice Bellard and the QEMU Project developers" > + --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OGbqiiqS6QIR8mgVgS32rEfBFpAdanEc3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXo1/6AAoJEKeha0olJ0NqxJUH/1w9PN4bSIzrSY5flb+Vc3fk er6lmvPlVv2yTvqWipT49R6SENjebMMzFelUEteKl96Cnh5zbJNkrxjAqcGCuT5G FemhFYGh7oodOGvf2rhChUakOV4UXeqPVhE3dkPQt05QtxYKIn1PueVO2Qex6VaX xQiBotxBYkkJJcUYbKRXzct6VQucR4h5VNoThIfAPIPYFREBnVrfrNjIVWV75xk7 3g7P8tk/AASNqg0aac/3iQHdgTUPcJGP29++qE08c2CYLvRpCgCr3eDMUgNeaOjO Byleel28wNNNZ0x314k/LOkqNI2IJo/Q39iRETtNbF42n2lU5YP19z18qMeQeME= =uh/m -----END PGP SIGNATURE----- --OGbqiiqS6QIR8mgVgS32rEfBFpAdanEc3--