From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVPLm-0002In-Ii for qemu-devel@nongnu.org; Thu, 04 Aug 2016 16:34:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVPLk-0001e9-AI for qemu-devel@nongnu.org; Thu, 04 Aug 2016 16:34:41 -0400 References: <1470129518-21087-1-git-send-email-famz@redhat.com> <1470129518-21087-4-git-send-email-famz@redhat.com> From: Eric Blake Message-ID: <57A3A6D8.1080500@redhat.com> Date: Thu, 4 Aug 2016 14:34:32 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Hh7JK15o0RLukNkhSeOM5bUe8sPGWjmn3" Subject: Re: [Qemu-devel] [PATCH 3/7] vdi: Use QEMU UUID API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org, mdroth@linux.vnet.ibm.com, armbru@redhat.com, pbonzini@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Hh7JK15o0RLukNkhSeOM5bUe8sPGWjmn3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2016 12:58 PM, Stefan Weil wrote: > Hi, >=20 > On 08/02/16 11:18, Fam Zheng wrote: >> The QEMU UUID api, including the data structure (qemu_uuid_t), is full= y >> compatible with libuuid. Use it, and remove the unused code. >> >> Signed-off-by: Fam Zheng >> --- >> block/vdi.c | 49 ++++++++++--------------------------------------- >> 1 file changed, 10 insertions(+), 39 deletions(-) >> >> @@ -182,10 +153,10 @@ typedef struct { >> uint32_t block_extra; /* unused here */ >> uint32_t blocks_in_image; >> uint32_t blocks_allocated; >> - uuid_t uuid_image; >> - uuid_t uuid_last_snap; >> - uuid_t uuid_link; >> - uuid_t uuid_parent; >> + qemu_uuid_t uuid_image; >> + qemu_uuid_t uuid_last_snap; >> + qemu_uuid_t uuid_link; >> + qemu_uuid_t uuid_parent; >=20 > As far as I remember, _t should be avoided because that postfix is > reserved by POSIX. Should we use qemu_uuid, or can we ignore POSIX > because the type name uses the qemu_ prefix? Correct that POSIX reserved all _t (which is a bit broad, oh well), and also correct that we can take the risk of using it anyways (but if POSIX ever standardizes something, we get to keep both of our broken pieces). > Either with qemu_uuid_t or with qemu_uuid: I thought our coding standard preferred QemuUUID or something similar in camelcase, rather than lower case. But now we are just painting a bikeshed, so I won't strongly object. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Hh7JK15o0RLukNkhSeOM5bUe8sPGWjmn3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXo6bYAAoJEKeha0olJ0NqzP0H/jDm5Cic64TCl4fa5DunPvXh mzQjMs05tIYAm9pR/aWI7QWkfdrF7Hbzz2QDp4GJWjz0/PPeJC6brn5VM2kYaMOL ZKMCXZx3bScZ7mdqfR3nNXnRaU5NrVpoSLYyQsCD7JvITBoCO9369sireLhVykfO p8AdmqoxrNOTkkd1itreYEX2EdUKoLspD03xp3+hUA4+8DWKkJXoFdi8cpGihv1U wQ7LH5VnHHmY3iTYDJGt29ThbE18MAEReOpeNo6Slp9JNJCHl4nILV0ALiUEz8He yY7Da84x2A/QKVJSZlCKS9ZAgO87Dm1VvS6VtxhGDkHvLTkad5lxcAnpIaOE79U= =4kt4 -----END PGP SIGNATURE----- --Hh7JK15o0RLukNkhSeOM5bUe8sPGWjmn3--