From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVPc4-0002NT-D2 for qemu-devel@nongnu.org; Thu, 04 Aug 2016 16:51:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVPby-0005Zq-ER for qemu-devel@nongnu.org; Thu, 04 Aug 2016 16:51:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58468) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVPby-0005Zm-7x for qemu-devel@nongnu.org; Thu, 04 Aug 2016 16:51:26 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF4638553E for ; Thu, 4 Aug 2016 20:51:25 +0000 (UTC) References: <1470224274-31522-1-git-send-email-armbru@redhat.com> <1470224274-31522-4-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <57A3AACD.4000509@redhat.com> Date: Thu, 4 Aug 2016 14:51:25 -0600 MIME-Version: 1.0 In-Reply-To: <1470224274-31522-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Am3TDnJMTCpm7inuC4W1aujAKkCvR3XrF" Subject: Re: [Qemu-devel] [PATCH 3/4] vfio: Use error_report() instead of error_printf() for errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: Alex Williamson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Am3TDnJMTCpm7inuC4W1aujAKkCvR3XrF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/03/2016 05:37 AM, Markus Armbruster wrote: > Cc: Alex Williamson > Signed-off-by: Markus Armbruster > --- > hw/vfio/platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 Reviewed-by: Eric Blake > diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c > index 1798a00..a559e7b 100644 > --- a/hw/vfio/platform.c > +++ b/hw/vfio/platform.c > @@ -496,7 +496,7 @@ static int vfio_populate_device(VFIODevice *vbasede= v) > irq.index =3D i; > ret =3D ioctl(vbasedev->fd, VFIO_DEVICE_GET_IRQ_INFO, &irq); > if (ret) { > - error_printf("vfio: error getting device %s irq info", > + error_report("vfio: error getting device %s irq info", > vbasedev->name); > goto irq_err; > } else { >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Am3TDnJMTCpm7inuC4W1aujAKkCvR3XrF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXo6rNAAoJEKeha0olJ0NqLFYH/0Nh+jOc8WyE8Q+W67H0nRZR 0Uf7TvysEjpioYsb2q2VrJJJ9xZUuSUJGGIDVWeQX0wkbCZtgJxn2A3nYIiPrZAm eq+Y+1Zc/sC6ANKiPvX2a2YR6DfvKAOWWBanLLU7BP5cjl2AhXhi80AqxwM0O6ll wgDCcr/7iCS4byvWqaKg/GEpRRCJzfSf7JTFdwuO6uao51hW0lDkKL4yej2qZx4H ci3U2FLoS5CVcbFbTkl/UpyTtpzbEvsWKZxzxhWjMjnWL3Xjy/YUIomKSKMqBvC5 9zRzBJIKdeEdhpfnbMYwEwUBUIXnjDIWhaJ4d0+iHK3UCIFpq/AAZzesExC2em4= =HYmh -----END PGP SIGNATURE----- --Am3TDnJMTCpm7inuC4W1aujAKkCvR3XrF--