qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>, qemu-ppc@nongnu.org
Cc: david@gibson.dropbear.id.au, qemu-devel@nongnu.org,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] ppc: Rename #include'd .c files to .inc.c
Date: Fri, 5 Aug 2016 11:32:24 -0600	[thread overview]
Message-ID: <57A4CDA8.7050001@redhat.com> (raw)
In-Reply-To: <1469745026.5978.235.camel@kernel.crashing.org>

[-- Attachment #1: Type: text/plain, Size: 1940 bytes --]

On 07/28/2016 04:30 PM, Benjamin Herrenschmidt wrote:
> Also while at it, group the #include statements in translate.c
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>  target-ppc/translate.c              |   40 +-
>  target-ppc/translate/dfp-impl.c     |  212 ------
>  target-ppc/translate/dfp-impl.inc.c |  212 ++++++
>  target-ppc/translate/dfp-ops.c      |  151 -----
>  target-ppc/translate/dfp-ops.inc.c  |  151 +++++
>  target-ppc/translate/fp-impl.c      | 1070 ------------------------------
>  target-ppc/translate/fp-impl.inc.c  | 1070 ++++++++++++++++++++++++++++++
>  target-ppc/translate/fp-ops.c       |  111 ----
>  target-ppc/translate/fp-ops.inc.c   |  111 ++++
>  target-ppc/translate/spe-impl.c     | 1229 -----------------------------------
>  target-ppc/translate/spe-impl.inc.c | 1229 +++++++++++++++++++++++++++++++++++
>  target-ppc/translate/spe-ops.c      |  106 ---
>  target-ppc/translate/spe-ops.inc.c  |  106 +++
>  target-ppc/translate/vmx-impl.c     |  813 -----------------------
>  target-ppc/translate/vmx-impl.inc.c |  813 +++++++++++++++++++++++
>  target-ppc/translate/vmx-ops.c      |  246 -------
>  target-ppc/translate/vmx-ops.inc.c  |  246 +++++++
>  target-ppc/translate/vsx-impl.c     |  715 --------------------
>  target-ppc/translate/vsx-impl.inc.c |  715 ++++++++++++++++++++
>  target-ppc/translate/vsx-ops.c      |  271 --------
>  target-ppc/translate/vsx-ops.inc.c  |  271 ++++++++
>  21 files changed, 4944 insertions(+), 4944 deletions(-)

Per http://wiki.qemu.org/Contribute/SubmitAPatch, if you would do:

git config diff.renames true

then your email would be MUCH smaller, calling our attention to what
changed to accommodate the rename rather than treating the entire file
as deleted than new contents.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  parent reply	other threads:[~2016-08-05 17:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 22:30 [Qemu-devel] [PATCH] ppc: Rename #include'd .c files to .inc.c Benjamin Herrenschmidt
2016-07-29  4:37 ` David Gibson
2016-08-05 17:32 ` Eric Blake [this message]
2016-08-05 22:40   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57A4CDA8.7050001@redhat.com \
    --to=eblake@redhat.com \
    --cc=benh@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).