From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45221)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bfIgQ-0004Hp-P4
	for qemu-devel@nongnu.org; Wed, 31 Aug 2016 23:28:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bfIgM-0004hh-G1
	for qemu-devel@nongnu.org; Wed, 31 Aug 2016 23:28:53 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:64920)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bfIgL-0004hH-MK
	for qemu-devel@nongnu.org; Wed, 31 Aug 2016 23:28:50 -0400
References: <1470227172-13704-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1470227172-13704-3-git-send-email-zhang.zhanghailiang@huawei.com>
	<20160825214746.GB13560@localhost.localdomain>
From: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Message-ID: <57C7A01B.2070600@huawei.com>
Date: Thu, 1 Sep 2016 11:27:23 +0800
MIME-Version: 1.0
In-Reply-To: <20160825214746.GB13560@localhost.localdomain>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH COLO-Frame v18 02/34] migration: Introduce
 capability 'x-colo' to migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: peter.huangpeng@huawei.com, qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, eddie.dong@intel.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, zhangchen.fnst@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Gonglei <arei.gonglei@huawei.com>

On 2016/8/26 5:47, Amit Shah wrote:
> On (Wed) 03 Aug 2016 [20:25:40], zhanghailiang wrote:
>> We add helper function colo_supported() to indicate whether
>> colo is supported or not, with which we use to control whether or not
>> showing 'x-colo' string to users, they can use qmp command
>> 'query-migrate-capabilities' or hmp command 'info migrate_capabilities'
>> to learn if colo is supported.
>>
>> Cc: Juan Quintela <quintela@redhat.com>
>> Cc: Amit Shah <amit.shah@redhat.com>
>> Cc: Eric Blake <eblake@redhat.com>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>
>
>> +#include "qemu/osdep.h"
>> +#include "migration/colo.h"
>> +
>> +bool colo_supported(void)
>> +{
>> +    return true;
>> +}
>
> Can you start with this disabled, and returning true when all the
> pieces are done (ie close to the patches when the functionality is
> actually useful later in the series?).
>

Yes, i have done as your advise, please see the new version, thanks.

> .
>