From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgnpH-0002DP-Tq for qemu-devel@nongnu.org; Mon, 05 Sep 2016 02:56:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgnpB-0002On-W6 for qemu-devel@nongnu.org; Mon, 05 Sep 2016 02:56:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgnpB-0002OY-QU for qemu-devel@nongnu.org; Mon, 05 Sep 2016 02:56:09 -0400 References: <1472526419-5900-1-git-send-email-jasowang@redhat.com> <1472526419-5900-4-git-send-email-jasowang@redhat.com> From: Wei Xu Message-ID: <57CD1701.6070703@redhat.com> Date: Mon, 5 Sep 2016 14:56:01 +0800 MIME-Version: 1.0 In-Reply-To: <1472526419-5900-4-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for 2.8 03/11] intel_iommu: name vtd address space with devfn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , mst@redhat.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com, peterx@redhat.com, cornelia.huck@de.ibm.com, vkaplans@redhat.com, Richard Henderson , Eduardo Habkost On 2016=E5=B9=B408=E6=9C=8830=E6=97=A5 11:06, Jason Wang wrote: > To avoid duplicated name and ease debugging. > > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Acked-by: Peter Xu > Signed-off-by: Jason Wang > --- > hw/i386/intel_iommu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index 28c31a2..db70310 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -2303,6 +2303,7 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState = *s, PCIBus *bus, int devfn) > uintptr_t key =3D (uintptr_t)bus; > VTDBus *vtd_bus =3D g_hash_table_lookup(s->vtd_as_by_busptr, &key= ); > VTDAddressSpace *vtd_dev_as; > + char name[128]; > > if (!vtd_bus) { > /* No corresponding free() */ > @@ -2316,6 +2317,7 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState = *s, PCIBus *bus, int devfn) > vtd_dev_as =3D vtd_bus->dev_as[devfn]; > > if (!vtd_dev_as) { > + snprintf(name, sizeof(name), "intel_iommu_devfn_%d", devfn); > vtd_bus->dev_as[devfn] =3D vtd_dev_as =3D g_malloc0(sizeof(VT= DAddressSpace)); > > vtd_dev_as->bus =3D bus; > @@ -2330,7 +2332,7 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState = *s, PCIBus *bus, int devfn) > memory_region_add_subregion(&vtd_dev_as->iommu, VTD_INTERRUPT= _ADDR_FIRST, > &vtd_dev_as->iommu_ir); > address_space_init(&vtd_dev_as->as, > - &vtd_dev_as->iommu, "intel_iommu"); > + &vtd_dev_as->iommu, name); No need to use the name for iommu region as before? > } > return vtd_dev_as; > } >