From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45483)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wangww.fnst@cn.fujitsu.com>) id 1bp44r-0006iz-8m
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 21:54:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wangww.fnst@cn.fujitsu.com>) id 1bp44q-0004P3-AZ
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 21:54:29 -0400
Message-ID: <57EB228C.40708@cn.fujitsu.com>
Date: Wed, 28 Sep 2016 09:53:16 +0800
From: wangweiwei <wangww.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1469602913-20979-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<1469602913-20979-12-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<20160809090807.GB5030@noname.str.redhat.com>
	<57B11FC1.2070000@cn.fujitsu.com>
	<20160815083739.GA6024@noname.str.redhat.com>
	<57B18C23.50200@cn.fujitsu.com>
	<20160912140108.GA15756@stefanha-x1.localdomain>
In-Reply-To: <20160912140108.GA15756@stefanha-x1.localdomain>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v24 11/12] support replication
 driver in blockdev-add
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Wen Congyang <wency@cn.fujitsu.com>, Fam Zheng <famz@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu block <qemu-block@nongnu.org>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, qemu devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>, Gonglei <arei.gonglei@huawei.com>, "Dr. David Alan
	Gilbert" <dgilbert@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>

在 2016年09月12日 22:01, Stefan Hajnoczi 写道:
> On Mon, Aug 15, 2016 at 05:32:19PM +0800, Changlong Xie wrote:
>> On 08/15/2016 04:37 PM, Kevin Wolf wrote:
>>> Am 15.08.2016 um 03:49 hat Changlong Xie geschrieben:
>>>> On 08/09/2016 05:08 PM, Kevin Wolf wrote:
>>>>> Am 27.07.2016 um 09:01 hat Changlong Xie geschrieben:
>>>>>> From: Wen Congyang <wency@cn.fujitsu.com>
>>>>>>
>>>>>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>>>>>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>>>>>> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
>>>>>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>>>>>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>>>>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>>>>
>>>>>> @@ -2078,6 +2079,23 @@
>>>>>>    { 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
>>>>>>
>>>>>>    ##
>>>>>> +# @BlockdevOptionsReplication
>>>>>> +#
>>>>>> +# Driver specific block device options for replication
>>>>>> +#
>>>>>> +# @mode: the replication mode
>>>>>> +#
>>>>>> +# @top-id: #optional In secondary mode, node name or device ID of the root
>>>>>> +#          node who owns the replication node chain. Ignored in primary mode.
>>>>>
>>>>> Can we change this to "Must not be given in primary mode"? Not sure what
>>>>> the code currently does, but I think it should error out if top-id is
>>>>
>>>> Replication driver will ignore "top-id" parameter in Primary mode.
>>>
>>> This is not good behaviour, which is why I requested a change.
>>>
>>
>> Hi stefan
>>
>> Would you like me send another [PATCH v25] based your block-next? Or a
>> separate patch until your tree is merged.
>
> Sorry for the slow response.  Please send a new patch on top of my
> block-next tree.
>
> Stefan
>
ok, I will send a new patch on the top of block-next tree.