From: Tom Hanson <thomas.hanson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Grant Likely <grant.likely@hpe.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] target-arm: Comments to mark location of pending work for 56 bit addresses
Date: Mon, 3 Oct 2016 11:01:05 -0600 [thread overview]
Message-ID: <57F28ED1.4020506@linaro.org> (raw)
In-Reply-To: <CAFEAcA_dqm6VgUvoTez8Mcu_Tcv9V+Tng46kw7gSsR+ohfW6QA@mail.gmail.com>
On 09/30/2016 05:24 PM, Peter Maydell wrote:
>>>> 3 comments added in same file to identify cases in a switch.
>>>
>>> This should be a separate patch, because it is unrelated to the
>>> tagged address stuff.
>>
>> As part of that same conversation you suggested adding these
>> comments rather than making the changes:
>> If we can assert, or failing that have a comment in the place
>> that would be modified anyway for 56 bit addresses then that
>> ought to catch the future case I think.
>
> Yes, I still think this. What does it have to do with adding
> "SVC", "HVC", etc comments to the switch cases? Those have
> nothing to do with tagged addresses or 56 bit VAs, and should
> not be in this patch (though I don't object to them inherently).
>
> thanks
> -- PMM
Sorry, moving too fast and didn't look at which comments you were referring to. I'll drop them.
-Tom
next prev parent reply other threads:[~2016-10-03 17:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 17:34 [Qemu-devel] [PATCH 0/3] tareget-arm: Handle tagged addresses when loading PC Thomas Hanson
2016-09-16 17:34 ` [Qemu-devel] [PATCH 1/3] target-arm: Infrastucture changes to enable handling of tagged address loading into PC Thomas Hanson
2016-09-30 0:58 ` Peter Maydell
2016-09-16 17:34 ` [Qemu-devel] [PATCH 2/3] target-arm: Code changes to implement overwrite of tag field on PC load Thomas Hanson
2016-09-30 1:24 ` Peter Maydell
2016-10-05 21:53 ` Tom Hanson
2016-10-05 22:01 ` Peter Maydell
2016-10-11 15:51 ` Thomas Hanson
2016-10-11 16:02 ` Richard Henderson
2016-10-11 16:12 ` Peter Maydell
2016-10-12 19:52 ` Tom Hanson
2016-09-16 17:34 ` [Qemu-devel] [PATCH 3/3] target-arm: Comments to mark location of pending work for 56 bit addresses Thomas Hanson
2016-09-30 1:27 ` Peter Maydell
2016-09-30 22:46 ` Tom Hanson
2016-09-30 23:24 ` Peter Maydell
2016-10-03 17:01 ` Tom Hanson [this message]
2016-10-03 18:26 ` Tom Hanson
2016-09-30 1:37 ` [Qemu-devel] [PATCH 0/3] tareget-arm: Handle tagged addresses when loading PC Peter Maydell
2016-09-30 21:48 ` Tom Hanson
2016-09-30 22:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57F28ED1.4020506@linaro.org \
--to=thomas.hanson@linaro.org \
--cc=grant.likely@hpe.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).