From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btnpa-0008TC-Ol for qemu-devel@nongnu.org; Mon, 10 Oct 2016 23:34:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btnpX-0005RD-LF for qemu-devel@nongnu.org; Mon, 10 Oct 2016 23:34:18 -0400 Received: from [59.151.112.132] (port=56791 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btnpW-0005Mq-9w for qemu-devel@nongnu.org; Mon, 10 Oct 2016 23:34:15 -0400 References: <1473839464-8670-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1473839464-8670-9-git-send-email-caoj.fnst@cn.fujitsu.com> <87k2du7oo7.fsf@dusky.pond.sub.org> <57EE0CFB.4070002@cn.fujitsu.com> <878tu9ttzv.fsf@dusky.pond.sub.org> <017DDFF7-F80A-4C07-B533-4BEBEEA641CE@daynix.com> From: Cao jin Message-ID: <57FC5DFE.4070708@cn.fujitsu.com> Date: Tue, 11 Oct 2016 11:35:26 +0800 MIME-Version: 1.0 In-Reply-To: <017DDFF7-F80A-4C07-B533-4BEBEEA641CE@daynix.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 8/8] vmxnet3: remove unnecessary internal msix state flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Fleytman , Markus Armbruster Cc: Marcel Apfelbaum , Jason Wang , qemu-devel@nongnu.org, "Michael S. Tsirkin" On 10/06/2016 05:39 PM, Dmitry Fleytman wrote: > > > Hello, > > Yes, from what I see, this call is wrong and leads to > reference leaks on device unload at migration target. > It should be removed. > > Best regards, > Dmitry > Hi,Dmitry From what I saw, current code will call msix_vector_use twice on migration target, which is wrong. I am not quite follow you on "reference leak", are you saying the same thing as me? if not, could you help to explain more? -- Yours Sincerely, Cao jin