From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
qemu devel <qemu-devel@nongnu.org>,
qemu block <qemu-block@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>, Fam Zheng <famz@redhat.com>,
Eric Blake <eblake@redhat.com>,
Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [Questions] NBD issue or CoMutex->holder issue?
Date: Wed, 12 Oct 2016 08:42:50 +0800 [thread overview]
Message-ID: <57FD870A.5070902@cn.fujitsu.com> (raw)
In-Reply-To: <41ca850c-034f-156d-0551-2ecb649c1bb0@redhat.com>
On 10/11/2016 06:47 PM, Paolo Bonzini wrote:
>> the free_sema->queue head, so set free_sema->holder as
>> >revelant coroutine.
> NBD is using the CoMutex in a way that wasn't anticipated. The simplest
> fix is to change it to CoQueue, which is like a condition variable.
> Instead of locking if in_flight >= MAX_NBD_REQUESTS - 1, wait on the
> queue while in_flight == MAX_NBD_REQUESTS. Instead of unlocking, use
> qemu_co_queue_next to wake up one request.
>
Thanks for your explanation! will send out a patch later.
Thanks
-Xie
> Thanks for the report!
>
> Paolo
>
>> >For example if there are N(N=26 and MAX_NBD_REQUESTS=16) nbd write
>> >requests, so we'll invoke nbd_client_co_pwritev 26 times.
>> >time request No Actions
>> >1 1 in_flight=1, Coroutine=C1
>> >2 2 in_flight=2, Coroutine=C2
prev parent reply other threads:[~2016-10-12 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 10:35 [Qemu-devel] [Questions] NBD issue or CoMutex->holder issue? Changlong Xie
2016-10-11 10:47 ` Paolo Bonzini
2016-10-12 0:42 ` Changlong Xie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57FD870A.5070902@cn.fujitsu.com \
--to=xiecl.fnst@cn.fujitsu.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).