Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

[Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>]

On 5/10/2017 10:00 PM, Eric Blake wrote:
> On 05/10/2017 03:41 AM, Pradeep Jagadeesh wrote:
>> This patch enables qmp interfaces for the fsdev
>> devices. This provides two interfaces one
>> for querying info of all the fsdev devices. The second one
>> to set the IO limits for the required fsdev device.
>>
>> Signed-off-by: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>
>> ---
>
>> +++ b/qmp.c
>> @@ -130,6 +130,21 @@ void qmp_cpu_add(int64_t id, Error **errp)
>>      }
>>  }
>>
>> +#ifdef _WIN64
>> +
>> +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp)
>> +{
>> +  return;
>> +}
>> +
>> +IOThrottleList *qmp_query_fsdev_io_throttle(Error **errp)
>> +{
>> +    abort();
>> +}
>> +
>> +#endif
>
> I think you're missing an addition to monitor.c
> qmp_unregister_commands_hack() if you intend for this command to be
> available only on non-windows platforms (and is your #ifdef the correct
> name, or is this a Linux-only feature rather than a non-windows feature).
I had to add this one here because, I was getting some error when I 
cross compile for Windows. But I do not have any idea about, do I need 
to add in monitor.c or not.

Regards,
Pradeep
>