From: Michael Walle <michael@walle.cc>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Alistair Francis" <alistair@alistair23.me>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired
Date: Tue, 07 Jul 2020 22:22:59 +0200 [thread overview]
Message-ID: <57b75c41a564361350b4c871775d086e@walle.cc> (raw)
In-Reply-To: <CAFEAcA-oXwam0QmJaPnUnFLWsv62tKOcoCbqqj5W+Bn=yybLzg@mail.gmail.com>
Am 2020-07-07 18:30, schrieb Peter Maydell:
> On Sun, 5 Jul 2020 at 22:10, Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
>>
>> The 'card is readonly' and 'card inserted' IRQs are not wired.
>> Add a comment in case someone know where to wire them.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> hw/lm32/milkymist.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c
>> index 469e3c4322..117973c967 100644
>> --- a/hw/lm32/milkymist.c
>> +++ b/hw/lm32/milkymist.c
>> @@ -87,6 +87,7 @@ static DeviceState *milkymist_memcard_create(hwaddr
>> base)
>> dev = qdev_new("milkymist-memcard");
>> sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
>> sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
>> + /* FIXME wire 'card is readonly' and 'card inserted' IRQs? */
>
> It's possible that these lines are correctly not wired up
> (ie that the hardware does not provide any kind of indication
> of the r/o or insertion events). The milkymist mmc device is a
> very simple one. AIUI the RTL for the board is on github if
> anybody wants to go check.
That is correct, there are not indications nor are there any
interrupts.
-michael
next prev parent reply other threads:[~2020-07-07 20:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 21:10 [PATCH 0/4] hw/sd/milkymist: Do not create SD card within the SDHCI controller Philippe Mathieu-Daudé
2020-07-05 21:10 ` [PATCH 1/4] hw/lm32/milkymist: Un-inline milkymist_memcard_create() Philippe Mathieu-Daudé
2020-07-06 16:17 ` Alistair Francis
2020-07-05 21:10 ` [PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired Philippe Mathieu-Daudé
2020-07-06 16:19 ` Alistair Francis
2020-07-06 18:04 ` Philippe Mathieu-Daudé
2020-07-06 18:32 ` Alistair Francis
2020-07-07 2:06 ` Philippe Mathieu-Daudé
2020-07-07 15:57 ` Alistair Francis
2020-07-07 16:30 ` Peter Maydell
2020-07-07 20:22 ` Michael Walle [this message]
2020-07-05 21:10 ` [PATCH 3/4] hw/sd/milkymist: Create the SDBus at init() Philippe Mathieu-Daudé
2020-07-06 16:19 ` Alistair Francis
2020-07-05 21:10 ` [PATCH 4/4] hw/sd/milkymist: Do not create SD card within the SDHCI controller Philippe Mathieu-Daudé
2020-07-06 16:21 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57b75c41a564361350b4c871775d086e@walle.cc \
--to=michael@walle.cc \
--cc=alistair@alistair23.me \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).