qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paul Durrant <paul.durrant@citrix.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/block: clean up stake xen_disk trace entries
Date: Mon, 28 Jan 2019 14:40:05 +0100	[thread overview]
Message-ID: <57cd3429-41a3-48c5-4d06-5d203cf70f97@redhat.com> (raw)
In-Reply-To: <20190122145132.12571-1-paul.durrant@citrix.com>

Cc'ing QEMU Trivial.

On 1/22/19 3:51 PM, Paul Durrant wrote:
> This should have been removed then xen_disk.c was removed but I missed them.

... when xen_disk.c was removed (19f87870baa) ...

> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> ---
>  hw/block/trace-events | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/hw/block/trace-events b/hw/block/trace-events
> index 55e5a5500c..d0851953c5 100644
> --- a/hw/block/trace-events
> +++ b/hw/block/trace-events
> @@ -121,13 +121,6 @@ nvme_ub_db_wr_invalid_cqhead(uint32_t qid, uint16_t new_head) "completion queue
>  nvme_ub_db_wr_invalid_sq(uint32_t qid) "submission queue doorbell write for nonexistent queue, sqid=%"PRIu32", ignoring"
>  nvme_ub_db_wr_invalid_sqtail(uint32_t qid, uint16_t new_tail) "submission queue doorbell write value beyond queue size, sqid=%"PRIu32", new_head=%"PRIu16", ignoring"
>  
> -# hw/block/xen_disk.c
> -xen_disk_alloc(char *name) "%s"
> -xen_disk_init(char *name) "%s"
> -xen_disk_connect(char *name) "%s"
> -xen_disk_disconnect(char *name) "%s"
> -xen_disk_free(char *name) "%s"
> -
>  # hw/block/xen-block.c
>  xen_block_realize(const char *type, uint32_t disk, uint32_t partition) "%s d%up%u"
>  xen_block_connect(const char *type, uint32_t disk, uint32_t partition) "%s d%up%u"
> 

  parent reply	other threads:[~2019-01-28 13:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 14:51 [Qemu-devel] [PATCH] hw/block: clean up stake xen_disk trace entries Paul Durrant
2019-01-28 10:27 ` Paul Durrant
2019-01-28 13:40 ` Philippe Mathieu-Daudé [this message]
2019-01-28 13:51   ` Peter Maydell
2019-01-28 16:04 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57cd3429-41a3-48c5-4d06-5d203cf70f97@redhat.com \
    --to=philmd@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=paul.durrant@citrix.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).