* [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test
@ 2025-03-08 7:13 Cédric Le Goater
2025-03-08 7:26 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Cédric Le Goater @ 2025-03-08 7:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Thomas Huth, Bernhard Beschow, Cédric Le Goater
When commit 72cdd672e18c extended the ppc64 e500 test to add network
support, it forgot to require the 'user' netdev backend. Fix that.
Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test")
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
tests/functional/test_ppc64_e500.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/functional/test_ppc64_e500.py b/tests/functional/test_ppc64_e500.py
index 9ce7ae6c4798..f5fcad9f6b66 100755
--- a/tests/functional/test_ppc64_e500.py
+++ b/tests/functional/test_ppc64_e500.py
@@ -20,6 +20,7 @@ class E500Test(LinuxKernelTest):
def test_ppc64_e500_buildroot(self):
self.set_machine('ppce500')
+ self.require_netdev('user')
self.cpu = 'e5500'
uimage_path = self.ASSET_BR2_E5500_UIMAGE.fetch()
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test
2025-03-08 7:13 [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test Cédric Le Goater
@ 2025-03-08 7:26 ` Philippe Mathieu-Daudé
2025-03-09 9:49 ` Bernhard Beschow
2025-03-10 10:04 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-03-08 7:26 UTC (permalink / raw)
To: Cédric Le Goater, qemu-devel; +Cc: Thomas Huth, Bernhard Beschow
On 8/3/25 08:13, Cédric Le Goater wrote:
> When commit 72cdd672e18c extended the ppc64 e500 test to add network
> support, it forgot to require the 'user' netdev backend. Fix that.
>
> Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test")
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> tests/functional/test_ppc64_e500.py | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test
2025-03-08 7:13 [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test Cédric Le Goater
2025-03-08 7:26 ` Philippe Mathieu-Daudé
@ 2025-03-09 9:49 ` Bernhard Beschow
2025-03-10 10:04 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Bernhard Beschow @ 2025-03-09 9:49 UTC (permalink / raw)
To: Cédric Le Goater, qemu-devel; +Cc: Thomas Huth
Am 8. März 2025 07:13:28 UTC schrieb "Cédric Le Goater" <clg@redhat.com>:
>When commit 72cdd672e18c extended the ppc64 e500 test to add network
>support, it forgot to require the 'user' netdev backend. Fix that.
>
>Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test")
>Signed-off-by: Cédric Le Goater <clg@redhat.com>
>---
> tests/functional/test_ppc64_e500.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tests/functional/test_ppc64_e500.py b/tests/functional/test_ppc64_e500.py
>index 9ce7ae6c4798..f5fcad9f6b66 100755
>--- a/tests/functional/test_ppc64_e500.py
>+++ b/tests/functional/test_ppc64_e500.py
>@@ -20,6 +20,7 @@ class E500Test(LinuxKernelTest):
>
> def test_ppc64_e500_buildroot(self):
> self.set_machine('ppce500')
>+ self.require_netdev('user')
> self.cpu = 'e5500'
>
> uimage_path = self.ASSET_BR2_E5500_UIMAGE.fetch()
Thanks for taking care of it, Cédric.
Acked-by: Bernhard Beschow <shentey@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test
2025-03-08 7:13 [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test Cédric Le Goater
2025-03-08 7:26 ` Philippe Mathieu-Daudé
2025-03-09 9:49 ` Bernhard Beschow
@ 2025-03-10 10:04 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2025-03-10 10:04 UTC (permalink / raw)
To: Cédric Le Goater, qemu-devel; +Cc: Bernhard Beschow, QEMU Trivial
On 08/03/2025 08.13, Cédric Le Goater wrote:
> When commit 72cdd672e18c extended the ppc64 e500 test to add network
> support, it forgot to require the 'user' netdev backend. Fix that.
>
> Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test")
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> tests/functional/test_ppc64_e500.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/functional/test_ppc64_e500.py b/tests/functional/test_ppc64_e500.py
> index 9ce7ae6c4798..f5fcad9f6b66 100755
> --- a/tests/functional/test_ppc64_e500.py
> +++ b/tests/functional/test_ppc64_e500.py
> @@ -20,6 +20,7 @@ class E500Test(LinuxKernelTest):
>
> def test_ppc64_e500_buildroot(self):
> self.set_machine('ppce500')
> + self.require_netdev('user')
> self.cpu = 'e5500'
Thanks, that should fix the issue that I saw in the
"functional-cfi-ppc64-s390x" job in the gitlab CI (which uses
--disable-slirp indeed)!
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-10 10:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-08 7:13 [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test Cédric Le Goater
2025-03-08 7:26 ` Philippe Mathieu-Daudé
2025-03-09 9:49 ` Bernhard Beschow
2025-03-10 10:04 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).