From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buDil-0002ly-Bn for qemu-devel@nongnu.org; Wed, 12 Oct 2016 03:13:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buDii-0000YB-3q for qemu-devel@nongnu.org; Wed, 12 Oct 2016 03:12:59 -0400 Received: from mail-io0-x242.google.com ([2607:f8b0:4001:c06::242]:36660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buDih-0000Xc-VF for qemu-devel@nongnu.org; Wed, 12 Oct 2016 03:12:56 -0400 Received: by mail-io0-x242.google.com with SMTP id o141so2520095ioe.3 for ; Wed, 12 Oct 2016 00:12:55 -0700 (PDT) Message-ID: <57fde276.652f6b0a.4ba6d.b725@mx.google.com> From: Li Qiang Date: Wed, 12 Oct 2016 00:12:48 -0700 Subject: [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: groug@kaod.org, qemu-devel@nongnu.org Cc: Li Qiang From: Li Qiang In v9fs_link dispatch function, it doesn't put the 'oldfidp' fid object, this will make the 'oldfidp->ref' never reach to 0, thus leading a memory leak issue. This patch fix this. Signed-off-by: Li Qiang --- hw/9pfs/9p.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 8b50bfb..29f8b7a 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -2413,6 +2413,7 @@ static void v9fs_link(void *opaque) if (!err) { err = offset; } + put_fid(pdu, oldfidp); out: put_fid(pdu, dfidp); out_nofid: -- 1.8.3.1