From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH] ptimer: Remove old ptimer_init_with_bh() API
Date: Fri, 25 Oct 2019 17:35:32 -0400 [thread overview]
Message-ID: <5806249b-df06-80b7-e5c5-810414be8881@linaro.org> (raw)
In-Reply-To: <20191025142411.17085-1-peter.maydell@linaro.org>
On 10/25/19 10:24 AM, Peter Maydell wrote:
> Now all the users of ptimers have converted to the transaction-based
> API, we can remove ptimer_init_with_bh() and all the code paths
> that are used only by bottom-half based ptimers, and tidy up the
> documentation comments to consider the transaction-based API the
> only possibility.
>
> The code changes result from:
> * s->bh no longer exists
> * s->callback is now always non-NULL
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/ptimer.h | 45 +++++++++++-----------
> hw/core/ptimer.c | 91 ++++++++-------------------------------------
> 2 files changed, 36 insertions(+), 100 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2019-10-25 21:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 14:24 [PATCH] ptimer: Remove old ptimer_init_with_bh() API Peter Maydell
2019-10-25 21:35 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5806249b-df06-80b7-e5c5-810414be8881@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).