From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Greg Kurz <groug@kaod.org>
Subject: Re: [PULL 0/5] 9p queue 2020-10-15
Date: Sat, 17 Oct 2020 13:55:42 +0200 [thread overview]
Message-ID: <5809478.Xo1ZfStJPt@silver> (raw)
In-Reply-To: <CAFEAcA_ygiXU=Lh1iOPUDOsXu-cuVze-wDhc90wZ+r7C-BBesA@mail.gmail.com>
On Samstag, 17. Oktober 2020 12:50:13 CEST Peter Maydell wrote:
> On Thu, 15 Oct 2020 at 22:04, Christian Schoenebeck
>
> <qemu_oss@crudebyte.com> wrote:
> > The following changes since commit
57c98ea9acdcef5021f5671efa6475a5794a51c4:
> > Merge remote-tracking branch
> > 'remotes/kraxel/tags/ui-20201014-pull-request' into staging (2020-10-14
> > 13:56:06 +0100)>
> > are available in the Git repository at:
> > https://github.com/cschoenebeck/qemu.git tags/pull-9p-20201015
> >
> > for you to fetch changes up to 97a64ec211d051439b654950ed3f7cffc47d489b:
> > tests/9pfs: add local Tmkdir test (2020-10-15 16:11:17 +0200)
> >
> > ----------------------------------------------------------------
> > 9pfs: add tests using local fs driver
> >
> > The currently existing 9pfs test cases are all solely using the 9pfs
> > 'synth' fileystem driver, which is a very simple and purely simulated (in
> > RAM only) filesystem. There are issues though where the 'synth' fs driver
> > is not sufficient. For example the following two bugs need test cases
> > running the 9pfs 'local' fs driver:
> >
> > https://bugs.launchpad.net/qemu/+bug/1336794
> > https://bugs.launchpad.net/qemu/+bug/1877384
> >
> > This patch set for that reason introduces 9pfs test cases using the 9pfs
> > 'local' filesystem driver along to the already existing tests on 'synth'.
>
> Build failure, OSX:
>
> Compiling C object tests/qtest/libqos/libqos.fa.p/virtio-9p.c.o
> ../../tests/qtest/libqos/virtio-9p.c:37:17: error: implicit
> declaration of function 'get_current_dir_name' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> char *pwd = get_current_dir_name();
> ^
> ../../tests/qtest/libqos/virtio-9p.c:37:17: error: this function
> declaration is not a prototype [-Werror,-Wstrict-prototypes]
> ../../tests/qtest/libqos/virtio-9p.c:37:11: error: incompatible
> integer to pointer conversion initializing 'char *' with an expression
> of type 'int' [-Werror,-Wint-conversion]
> char *pwd = get_current_dir_name();
>
>
> thanks
> -- PMM
Oops, get_current_dir_name() is a GNU extension. I just enabled Cirrus-CI to
prevent this from happening again. Sorry Peter.
Am I supposed to rebase for v2 PRs?
Fix for this is currently test running:
> index 1524982634..d43647b3b7 100644
> --- a/tests/qtest/libqos/virtio-9p.c
> +++ b/tests/qtest/libqos/virtio-9p.c
> @@ -34,9 +34,9 @@ static char *concat_path(const char* a, const char* b)
>
> static void init_local_test_path(void)
> {
>
> - char *pwd = get_current_dir_name();
> + char *pwd = g_get_current_dir();
>
> local_test_path = concat_path(pwd, "qtest-9p-local");
>
> - free(pwd);
> + g_free(pwd);
>
> }
>
> /* Creates the directory for the 9pfs 'local' filesystem driver to access.
> */
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2020-10-17 11:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 14:14 [PULL 0/5] 9p queue 2020-10-15 Christian Schoenebeck
2020-10-08 18:34 ` [PULL 3/5] tests/9pfs: wipe local 9pfs test directory Christian Schoenebeck
2020-10-08 18:34 ` [PULL 5/5] tests/9pfs: add local Tmkdir test Christian Schoenebeck
2020-10-08 18:34 ` [PULL 2/5] tests/9pfs: introduce local tests Christian Schoenebeck
2020-10-08 18:34 ` [PULL 1/5] tests/9pfs: change qtest name prefix to synth Christian Schoenebeck
2020-10-08 18:34 ` [PULL 4/5] tests/9pfs: add virtio_9p_test_path() Christian Schoenebeck
2020-10-17 10:50 ` [PULL 0/5] 9p queue 2020-10-15 Peter Maydell
2020-10-17 11:55 ` Christian Schoenebeck [this message]
2020-10-17 12:59 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5809478.Xo1ZfStJPt@silver \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).