From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byiO3-0002Lz-Ox for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:46:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byiNz-0004f3-Tm for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:46:11 -0400 Received: from mga14.intel.com ([192.55.52.115]:16823) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1byiNz-0004eD-MN for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:46:07 -0400 References: <1477031080-12616-1-git-send-email-liang.z.li@intel.com> <1477031080-12616-2-git-send-email-liang.z.li@intel.com> From: Dave Hansen Message-ID: <580E3ACD.1080906@intel.com> Date: Mon, 24 Oct 2016 09:46:05 -0700 MIME-Version: 1.0 In-Reply-To: <1477031080-12616-2-git-send-email-liang.z.li@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v3 kernel 1/7] virtio-balloon: rework deflate to add page to a list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li , mst@redhat.com Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com, cornelia.huck@de.ibm.com, amit.shah@redhat.com On 10/20/2016 11:24 PM, Liang Li wrote: > Will allow faster notifications using a bitmap down the road. > balloon_pfn_to_page() can be removed because it's useless. This is a pretty terse description of what's going on here. Could you try to elaborate a bit? What *is* the current approach? Why does it not work going forward? What do you propose instead? Why is it better?