From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byiUt-0000Ax-TR for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:53:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byiUq-0008Gi-1W for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:53:15 -0400 Received: from mga01.intel.com ([192.55.52.88]:1311) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1byiUp-0008GB-PT for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:53:11 -0400 References: <1477031080-12616-1-git-send-email-liang.z.li@intel.com> <1477031080-12616-4-git-send-email-liang.z.li@intel.com> From: Dave Hansen Message-ID: <580E3C76.3010205@intel.com> Date: Mon, 24 Oct 2016 09:53:10 -0700 MIME-Version: 1.0 In-Reply-To: <1477031080-12616-4-git-send-email-liang.z.li@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v3 kernel 3/7] mm: add a function to get the max pfn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li , mst@redhat.com Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com, cornelia.huck@de.ibm.com, amit.shah@redhat.com, Andrew Morton , Mel Gorman On 10/20/2016 11:24 PM, Liang Li wrote: > Expose the function to get the max pfn, so it can be used in the > virtio-balloon device driver. Simply include the 'linux/bootmem.h' > is not enough, if the device driver is built to a module, directly > refer the max_pfn lead to build failed. I'm not sure the rest of the set is worth reviewing. I think a lot of it will change pretty fundamentally once you have those improved data structures in place.