From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bzOhB-0005z5-Er
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 09:56:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bzOh6-0007Du-HU
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 09:56:45 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:60191)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bzOh6-0007C7-4p
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 09:56:40 -0400
References: <1476792613-11712-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1476792613-11712-5-git-send-email-zhang.zhanghailiang@huawei.com>
	<20161026050119.GD1679@amit-lp.rh>
From: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Message-ID: <5810B5E7.2040105@huawei.com>
Date: Wed, 26 Oct 2016 21:55:51 +0800
MIME-Version: 1.0
In-Reply-To: <20161026050119.GD1679@amit-lp.rh>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 04/17] migration:
 Switch to COLO process after finishing loadvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com

On 2016/10/26 13:01, Amit Shah wrote:
> On (Tue) 18 Oct 2016 [20:10:00], zhanghailiang wrote:
>> Switch from normal migration loadvm process into COLO checkpoint process if
>> COLO mode is enabled.
>>
>> We add three new members to struct MigrationIncomingState,
>> 'have_colo_incoming_thread' and 'colo_incoming_thread' record the COLO
>> related thread for secondary VM, 'migration_incoming_co' records the
>> original migration incoming coroutine.
>>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> (snip)
>
>> +void migration_incoming_exit_colo(void)
>> +{
>> +    colo_info.colo_requested = 0;
>
> Please use 'true' and 'false' for bools.
>

Good catch, fix in next version.

Thanks,
hailiang

> Otherwise,
>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
>
>
> 		Amit
>
> .
>