From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40750)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bzPgj-0000Rb-EF
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:00:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bzPge-0003VJ-BM
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:00:20 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:31008)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1bzPgd-0003EP-JC
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:00:16 -0400
References: <1476792613-11712-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1476792613-11712-15-git-send-email-zhang.zhanghailiang@huawei.com>
	<20161026055810.GN1679@amit-lp.rh>
From: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Message-ID: <5810C4D9.1090603@huawei.com>
Date: Wed, 26 Oct 2016 22:59:37 +0800
MIME-Version: 1.0
In-Reply-To: <20161026055810.GN1679@amit-lp.rh>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 14/17] COLO:
 Implement the process of failover for primary VM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com

On 2016/10/26 13:58, Amit Shah wrote:
> On (Tue) 18 Oct 2016 [20:10:10], zhanghailiang wrote:
>> For primary side, if COLO gets failover request from users.
>> To be exact, gets 'x_colo_lost_heartbeat' command.
>> COLO thread will exit the loop while the failover BH does the
>> cleanup work and resumes VM.
>>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
>
>> @@ -162,9 +196,20 @@ static int colo_do_checkpoint_transaction(MigrationState *s,
>
>> @@ -280,8 +330,6 @@ out:
>>       if (local_err) {
>>           error_report_err(local_err);
>>       }
>> -    migrate_set_state(&s->state, MIGRATION_STATUS_COLO,
>> -                      MIGRATION_STATUS_COMPLETED);
>
> Yea, I guess this should not have been done in the previous patch to
> begin with?
>

Yes, I should not add this in patch 3, i will fix this in next version.

Thanks,
Hailiang

> 		Amit
>
> .
>