From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzPs4-0000fa-3O for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:12:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzPs0-0003Ib-Nq for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:12:04 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:22759) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzPs0-0003DU-7c for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:12:00 -0400 References: <1476792613-11712-1-git-send-email-zhang.zhanghailiang@huawei.com> <1476792613-11712-18-git-send-email-zhang.zhanghailiang@huawei.com> <20161026060746.GQ1679@amit-lp.rh> <79ca80e4-e13a-c0bf-c7d9-ec6cf0f8c7df@redhat.com> From: Hailiang Zhang Message-ID: <5810C7A2.9010308@huawei.com> Date: Wed, 26 Oct 2016 23:11:30 +0800 MIME-Version: 1.0 In-Reply-To: <79ca80e4-e13a-c0bf-c7d9-ec6cf0f8c7df@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Amit Shah Cc: xiecl.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com, quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, Gonglei On 2016/10/26 21:42, Eric Blake wrote: > On 10/26/2016 01:07 AM, Amit Shah wrote: >> On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: >>> configure --enable-colo/--disable-colo to switch COLO >>> support on/off. >>> COLO feature is enabled by default. >>> >>> Signed-off-by: zhanghailiang >>> Signed-off-by: Li Zhijian >>> Signed-off-by: Gonglei >>> Reviewed-by: Dr. David Alan Gilbert >> >> Reviewed-by: Amit Shah >> >>> v19: >>> - fix colo_supported() to return true >>> v11: >>> - Turn COLO on in default (Eric's suggestion) >> >> Can you recap why the suggestion was made to switch it on by default? > > If the feature doesn't depend on external libraries, then enabling > compilation by default will avoid bitrot. > I agreed. > But mentioning this rationale in the commit message never hurts :) > Good idea, i'll add this instruction in commit message. Thank you very much for your speedy reply. :)