From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3bN7-0005Y1-Sm for qemu-devel@nongnu.org; Sun, 06 Nov 2016 23:17:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3bN4-0006lQ-Nb for qemu-devel@nongnu.org; Sun, 06 Nov 2016 23:17:25 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:61589) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3bN4-0006ik-HE for qemu-devel@nongnu.org; Sun, 06 Nov 2016 23:17:22 -0500 References: <20161018215031.2575-1-marex@denx.de> <20161107035501.GA26260@roeck-us.net> From: Sandra Loosemore Message-ID: <58200049.6060306@codesourcery.com> Date: Sun, 6 Nov 2016 21:17:13 -0700 MIME-Version: 1.0 In-Reply-To: <20161107035501.GA26260@roeck-us.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V3,1/7] nios2: Add disas entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Guenter Roeck , Marek Vasut Cc: qemu-devel@nongnu.org, Jeff Da Silva , Chris Wulff , Yves Vandervennet , Ley Foon Tan , Richard Henderson On 11/06/2016 08:55 PM, Guenter Roeck wrote: > On Tue, Oct 18, 2016 at 11:50:25PM +0200, Marek Vasut wrote: >> Add nios2 disassembler support. This patch is composed from binutils files >> from commit "Opcodes and assembler support for Nios II R2". The files from >> binutils used in this patch are: >> >> include/opcode/nios2.h >> include/opcode/nios2r1.h >> include/opcode/nios2r2.h >> opcodes/nios2-opc.c >> opcodes/nios2-dis.c >> >> Signed-off-by: Marek Vasut >> Cc: Chris Wulff >> Cc: Jeff Da Silva >> Cc: Ley Foon Tan >> Cc: Sandra Loosemore >> Cc: Yves Vandervennet >> --- >> V3: No change >> V2: Replace the nios2.c with GPL2 licensed version > > checkpatch.pl reports: > > total: 1967 errors, 150 warnings, 3559 lines checked > > on this file. When applying it, git reports a number of whitespace problems. > > Is that expected ? > > Guenter I don't know what checkpatch.pl is, or what "errors" it might be complaining about, but I'd strongly discourage doing anything to this code that would cause it to diverge from the binutils code it was derived from, even trivial whitespace changes. That would only complicate propagating updates to the code to both components. (I can't say I have any such patches in my queue right now, but I also can't rule out such changes in the future....) -Sandra the nios2 binutils maintainer