[Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[zhanghailiang]

VM can not get into colo state unless users enable 'x-colo'
capability for migration, Here it is necessary to clarify
this.

Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
v2:
- Clarify colo state for RunState too as Eric suggested.
---
 qapi-schema.json | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index 5dc96af..04f5aab 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -176,8 +176,9 @@
 #
 # @guest-panicked: guest has been panicked as a result of guest OS panic
 #
-# @colo: guest is paused to save/restore VM state under colo checkpoint (since
-# 2.8)
+# @colo: guest is paused to save/restore VM state under colo checkpoint,
+#        VM can not get into this state unless colo capability is enabled
+#        for migration. (since 2.8)
 ##
 { 'enum': 'RunState',
   'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
@@ -462,7 +463,8 @@
 #
 # @failed: some error occurred during migration process.
 #
-# @colo: VM is in the process of fault tolerance. (since 2.8)
+# @colo: VM is in the process of fault tolerance, VM can not get into this
+#        state unless colo capability is enabled for migration. (since 2.8)
 #
 # Since: 2.3
 #
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

On 11/02/2016 02:44 AM, zhanghailiang wrote:
> VM can not get into colo state unless users enable 'x-colo'
> capability for migration, Here it is necessary to clarify
> this.
> 
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> v2:
> - Clarify colo state for RunState too as Eric suggested.
> ---
>  qapi-schema.json | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Hailiang Zhang]

ping ?

Anyone pick this up?

On 2016/11/2 22:04, Eric Blake wrote:
> On 11/02/2016 02:44 AM, zhanghailiang wrote:
>> VM can not get into colo state unless users enable 'x-colo'
>> capability for migration, Here it is necessary to clarify
>> this.
>>
>> Suggested-by: Eric Blake <eblake@redhat.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> ---
>> v2:
>> - Clarify colo state for RunState too as Eric suggested.
>> ---
>>   qapi-schema.json | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
>

Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
> ping ?
> 
> Anyone pick this up?

The original patch that added these lines went through Amit Shah and
David Gilbert.  I have CCed them.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Hailiang Zhang]

On 2016/11/14 21:54, Stefan Hajnoczi wrote:
> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>> ping ?
>>
>> Anyone pick this up?
>
> The original patch that added these lines went through Amit Shah and
> David Gilbert.  I have CCed them.
>

Great, thanks :)

> Stefan
>

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Laurent Vivier]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>> ping ?
>>
>> Anyone pick this up?
> 
> The original patch that added these lines went through Amit Shah and
> David Gilbert.  I have CCed them.

If it is needed, I can also send a pull request through my
trivial-patches branch.

Laurent


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Zhang Chen]

On 11/15/2016 04:44 PM, Laurent Vivier wrote:
> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>>> ping ?
>>>
>>> Anyone pick this up?
>> The original patch that added these lines went through Amit Shah and
>> David Gilbert.  I have CCed them.
> If it is needed, I can also send a pull request through my
> trivial-patches branch.
>
> Laurent

The pull request for this patch has been sent by Jason.
Thanks for your attention, and thank Stefan.

Zhang Chen


-- 
Thanks
zhangchen

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Hailiang Zhang]

On 2016/11/15 16:58, Zhang Chen wrote:
>
>
> On 11/15/2016 04:44 PM, Laurent Vivier wrote:
>> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>>>> ping ?
>>>>
>>>> Anyone pick this up?
>>> The original patch that added these lines went through Amit Shah and
>>> David Gilbert.  I have CCed them.
>> If it is needed, I can also send a pull request through my
>> trivial-patches branch.
>>
>> Laurent
>
> The pull request for this patch has been sent by Jason.
> Thanks for your attention, and thank Stefan.
>

Er, It seems that you made a mistake, Jason's pull request doesn't
contain this patch. no ?

Thanks,
Hailiang

> Zhang Chen
>
>

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Zhang Chen]

On 11/15/2016 05:03 PM, Hailiang Zhang wrote:
> On 2016/11/15 16:58, Zhang Chen wrote:
>>
>>
>> On 11/15/2016 04:44 PM, Laurent Vivier wrote:
>>> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>>>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>>>>> ping ?
>>>>>
>>>>> Anyone pick this up?
>>>> The original patch that added these lines went through Amit Shah and
>>>> David Gilbert.  I have CCed them.
>>> If it is needed, I can also send a pull request through my
>>> trivial-patches branch.
>>>
>>> Laurent
>>
>> The pull request for this patch has been sent by Jason.
>> Thanks for your attention, and thank Stefan.
>>
>
> Er, It seems that you made a mistake, Jason's pull request doesn't
> contain this patch. no ?
>
> Thanks,
> Hailiang
>

Oh...Sorry....I was wrong.
Please ignore this....

Thanks
Zhang Chen

>> Zhang Chen
>>
>>
>
>
>
> .
>

-- 
Thanks
zhangchen

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Hailiang Zhang]

Hi Laurent,

On 2016/11/15 16:44, Laurent Vivier wrote:
> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>>> ping ?
>>>
>>> Anyone pick this up?
>>
>> The original patch that added these lines went through Amit Shah and
>> David Gilbert.  I have CCed them.
>
> If it is needed, I can also send a pull request through my
> trivial-patches branch.
>

I think this patch can go through your trivial branch if Amit or Dave
didn't pick it up.

Thanks,
Hailiang

> Laurent
>

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Laurent Vivier]

Le 17/11/2016 à 08:08, Hailiang Zhang a écrit :
> Hi Laurent,
> 
> On 2016/11/15 16:44, Laurent Vivier wrote:
>> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>>>> ping ?
>>>>
>>>> Anyone pick this up?
>>>
>>> The original patch that added these lines went through Amit Shah and
>>> David Gilbert.  I have CCed them.
>>
>> If it is needed, I can also send a pull request through my
>> trivial-patches branch.
>>
> 
> I think this patch can go through your trivial branch if Amit or Dave
> didn't pick it up.

Stefan,

can I send a pull request for this while we are in hard freeze phase or
should we wait the end of the release?

Thanks,
Laurent

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

On Thu, Nov 17, 2016 at 08:52:12AM +0100, Laurent Vivier wrote:
> Le 17/11/2016 à 08:08, Hailiang Zhang a écrit :
> > Hi Laurent,
> > 
> > On 2016/11/15 16:44, Laurent Vivier wrote:
> >> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
> >>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
> >>>> ping ?
> >>>>
> >>>> Anyone pick this up?
> >>>
> >>> The original patch that added these lines went through Amit Shah and
> >>> David Gilbert.  I have CCed them.
> >>
> >> If it is needed, I can also send a pull request through my
> >> trivial-patches branch.
> >>
> > 
> > I think this patch can go through your trivial branch if Amit or Dave
> > didn't pick it up.
> 
> Stefan,
> 
> can I send a pull request for this while we are in hard freeze phase or
> should we wait the end of the release?

Yes, it's a fix for incomplete documentation.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]