[Qemu-devel] [PATCH] 9pfs: adjust the order of resource cleanup in device unrealize

[Qemu-devel] [PATCH] 9pfs: adjust the order of resource cleanup in device unrealize

[Li Qiang]

From: Li Qiang <liq3ea@gmail.com>

Unrealize should undo things that were set during realize in
reverse order. This is what this patch does.

Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
 hw/9pfs/9p.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index aea7e9d..f7e14ac 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -3530,8 +3530,8 @@ out:
 
 void v9fs_device_unrealize_common(V9fsState *s, Error **errp)
 {
-    g_free(s->ctx.fs_root);
     g_free(s->tag);
+    g_free(s->ctx.fs_root);
 }
 
 typedef struct VirtfsCoResetData {
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] 9pfs: adjust the order of resource cleanup in device unrealize

[Greg Kurz]

Hi Li,

Please incorporate this patch in your cleanup series since it depends on it.

On Mon, 14 Nov 2016 20:38:57 -0500
Li Qiang <liq3ea@gmail.com> wrote:

> From: Li Qiang <liq3ea@gmail.com>
> 
> Unrealize should undo things that were set during realize in
> reverse order. This is what this patch does.
> 

So should do the error path in realize actually. :)

> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
>  hw/9pfs/9p.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index aea7e9d..f7e14ac 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -3530,8 +3530,8 @@ out:
>  
>  void v9fs_device_unrealize_common(V9fsState *s, Error **errp)
>  {
> -    g_free(s->ctx.fs_root);
>      g_free(s->tag);
> +    g_free(s->ctx.fs_root);
>  }
>  
>  typedef struct VirtfsCoResetData {