* [Qemu-devel] [PATCH] audio: es1370: add exit function
@ 2016-11-29 10:48 Li Qiang
2016-12-13 8:55 ` Li Qiang
0 siblings, 1 reply; 3+ messages in thread
From: Li Qiang @ 2016-11-29 10:48 UTC (permalink / raw)
To: kraxel, qemu-devel; +Cc: Li Qiang
From: Li Qiang <liqiang6-s@360.cn>
Currently the es1370 device emulation doesn't have a exit function,
hot unplug this device will leak some leak. Add a exit function to
avoid this.
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
---
hw/audio/es1370.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c
index 8449b5f..8f70f72 100644
--- a/hw/audio/es1370.c
+++ b/hw/audio/es1370.c
@@ -1041,6 +1041,13 @@ static void es1370_realize(PCIDevice *dev, Error **errp)
es1370_reset (s);
}
+static void es1370_exit(PCIDevice *dev)
+{
+ ES1370State *s = ES1370(dev);
+
+ AUD_remove_card(&s->card);
+}
+
static int es1370_init (PCIBus *bus)
{
pci_create_simple (bus, -1, TYPE_ES1370);
@@ -1053,6 +1060,7 @@ static void es1370_class_init (ObjectClass *klass, void *data)
PCIDeviceClass *k = PCI_DEVICE_CLASS (klass);
k->realize = es1370_realize;
+ k->exit = es1370_exit;
k->vendor_id = PCI_VENDOR_ID_ENSONIQ;
k->device_id = PCI_DEVICE_ID_ENSONIQ_ES1370;
k->class_id = PCI_CLASS_MULTIMEDIA_AUDIO;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] audio: es1370: add exit function
2016-11-29 10:48 [Qemu-devel] [PATCH] audio: es1370: add exit function Li Qiang
@ 2016-12-13 8:55 ` Li Qiang
2016-12-13 17:46 ` Marc-André Lureau
0 siblings, 1 reply; 3+ messages in thread
From: Li Qiang @ 2016-12-13 8:55 UTC (permalink / raw)
To: kraxel, qemu-devel; +Cc: Li Qiang
ping!
2016-11-29 18:48 GMT+08:00 Li Qiang <liq3ea@gmail.com>:
> From: Li Qiang <liqiang6-s@360.cn>
>
> Currently the es1370 device emulation doesn't have a exit function,
> hot unplug this device will leak some leak. Add a exit function to
> avoid this.
>
> Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> ---
> hw/audio/es1370.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c
> index 8449b5f..8f70f72 100644
> --- a/hw/audio/es1370.c
> +++ b/hw/audio/es1370.c
> @@ -1041,6 +1041,13 @@ static void es1370_realize(PCIDevice *dev, Error
> **errp)
> es1370_reset (s);
> }
>
> +static void es1370_exit(PCIDevice *dev)
> +{
> + ES1370State *s = ES1370(dev);
> +
> + AUD_remove_card(&s->card);
> +}
> +
> static int es1370_init (PCIBus *bus)
> {
> pci_create_simple (bus, -1, TYPE_ES1370);
> @@ -1053,6 +1060,7 @@ static void es1370_class_init (ObjectClass *klass,
> void *data)
> PCIDeviceClass *k = PCI_DEVICE_CLASS (klass);
>
> k->realize = es1370_realize;
> + k->exit = es1370_exit;
> k->vendor_id = PCI_VENDOR_ID_ENSONIQ;
> k->device_id = PCI_DEVICE_ID_ENSONIQ_ES1370;
> k->class_id = PCI_CLASS_MULTIMEDIA_AUDIO;
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] audio: es1370: add exit function
2016-12-13 8:55 ` Li Qiang
@ 2016-12-13 17:46 ` Marc-André Lureau
0 siblings, 0 replies; 3+ messages in thread
From: Marc-André Lureau @ 2016-12-13 17:46 UTC (permalink / raw)
To: Li Qiang, kraxel, qemu-devel; +Cc: Li Qiang
good, and could be better, see my ac97 review
On Tue, Dec 13, 2016 at 11:57 AM Li Qiang <liq3ea@gmail.com> wrote:
> ping!
>
> 2016-11-29 18:48 GMT+08:00 Li Qiang <liq3ea@gmail.com>:
>
> > From: Li Qiang <liqiang6-s@360.cn>
> >
> > Currently the es1370 device emulation doesn't have a exit function,
> > hot unplug this device will leak some leak. Add a exit function to
> > avoid this.
> >
> > Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> > ---
> > hw/audio/es1370.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c
> > index 8449b5f..8f70f72 100644
> > --- a/hw/audio/es1370.c
> > +++ b/hw/audio/es1370.c
> > @@ -1041,6 +1041,13 @@ static void es1370_realize(PCIDevice *dev, Error
> > **errp)
> > es1370_reset (s);
> > }
> >
> > +static void es1370_exit(PCIDevice *dev)
> > +{
> > + ES1370State *s = ES1370(dev);
> > +
> > + AUD_remove_card(&s->card);
> > +}
> > +
> > static int es1370_init (PCIBus *bus)
> > {
> > pci_create_simple (bus, -1, TYPE_ES1370);
> > @@ -1053,6 +1060,7 @@ static void es1370_class_init (ObjectClass *klass,
> > void *data)
> > PCIDeviceClass *k = PCI_DEVICE_CLASS (klass);
> >
> > k->realize = es1370_realize;
> > + k->exit = es1370_exit;
> > k->vendor_id = PCI_VENDOR_ID_ENSONIQ;
> > k->device_id = PCI_DEVICE_ID_ENSONIQ_ES1370;
> > k->class_id = PCI_CLASS_MULTIMEDIA_AUDIO;
> > --
> > 1.8.3.1
> >
> >
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-13 17:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-29 10:48 [Qemu-devel] [PATCH] audio: es1370: add exit function Li Qiang
2016-12-13 8:55 ` Li Qiang
2016-12-13 17:46 ` Marc-André Lureau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).