From: "Longpeng (Mike)" <longpeng2@huawei.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: eblake@redhat.com, armbru@redhat.com, arei.gonglei@huawei.com,
qemu-devel@nongnu.org, wu.wubin@huawei.com,
jianjay.zhou@huawei.com
Subject: Re: [Qemu-devel] [PATCH for-2.9 3/3] tests: crypto: add testcase for standard des(ecb)
Date: Mon, 5 Dec 2016 17:46:00 +0800 [thread overview]
Message-ID: <58453758.8020604@huawei.com> (raw)
In-Reply-To: <20161205092434.GB2498@redhat.com>
Hi Daniel,
On 2016/12/5 17:24, Daniel P. Berrange wrote:
> On Mon, Dec 05, 2016 at 04:59:40PM +0800, Longpeng(Mike) wrote:
......
>> {
>> + .path = "/crypto/cipher/des-ecb",
>> + .alg = QCRYPTO_CIPHER_ALG_DES,
>> + .mode = QCRYPTO_CIPHER_MODE_ECB,
>> + .key =
>> + "0123456789abcdef",
>> + .plaintext =
>> + "0123456789abcde7",
>> + .ciphertext =
>> + "c95744256a5ed31d",
>> + },
>> + {
>> .path = "/crypto/cipher/des-rfb-ecb-56",
>> .alg = QCRYPTO_CIPHER_ALG_DES_RFB,
>> .mode = QCRYPTO_CIPHER_MODE_ECB,
>
> This should be included as part of the patch which adds the cipher
> in the first place. Ideally there should be a CBC mode test as well.
>
Okay.
I will put this in the first patch(which adds the cipher) and add a cbc(aes)
testcase in v2. :)
> Regards,
> Daniel
--
Regards,
Longpeng(Mike)
prev parent reply other threads:[~2016-12-05 9:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 8:59 [Qemu-devel] [PATCH for-2.9 0/3] crypto: add standard des support Longpeng(Mike)
2016-12-05 8:59 ` [Qemu-devel] [PATCH for-2.9 1/3] " Longpeng(Mike)
2016-12-05 9:18 ` Daniel P. Berrange
2016-12-05 9:29 ` Gonglei (Arei)
2016-12-05 16:59 ` Daniel P. Berrange
2016-12-06 1:23 ` Gonglei (Arei)
2016-12-06 9:21 ` Daniel P. Berrange
2016-12-06 9:28 ` Gonglei (Arei)
2016-12-05 11:11 ` Longpeng (Mike)
2016-12-05 11:18 ` Daniel P. Berrange
2016-12-05 19:15 ` Eric Blake
2016-12-07 0:58 ` Longpeng (Mike)
2016-12-05 8:59 ` [Qemu-devel] [PATCH for-2.9 2/3] cryptodev: switch to standard des Longpeng(Mike)
2016-12-05 9:25 ` Daniel P. Berrange
2016-12-05 8:59 ` [Qemu-devel] [PATCH for-2.9 3/3] tests: crypto: add testcase for standard des(ecb) Longpeng(Mike)
2016-12-05 9:24 ` Daniel P. Berrange
2016-12-05 9:46 ` Longpeng (Mike) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58453758.8020604@huawei.com \
--to=longpeng2@huawei.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jianjay.zhou@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).