From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34229)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <longpeng2@huawei.com>) id 1cDps6-00077Y-E9
	for qemu-devel@nongnu.org; Mon, 05 Dec 2016 04:47:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <longpeng2@huawei.com>) id 1cDps2-0005Lj-Ij
	for qemu-devel@nongnu.org; Mon, 05 Dec 2016 04:47:42 -0500
Received: from szxga01-in.huawei.com ([58.251.152.64]:32090)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)
	(envelope-from <longpeng2@huawei.com>) id 1cDprx-0005CD-M8
	for qemu-devel@nongnu.org; Mon, 05 Dec 2016 04:47:38 -0500
Message-ID: <58453758.8020604@huawei.com>
Date: Mon, 5 Dec 2016 17:46:00 +0800
From: "Longpeng (Mike)" <longpeng2@huawei.com>
MIME-Version: 1.0
References: <1480928380-161760-1-git-send-email-longpeng2@huawei.com>
	<1480928380-161760-4-git-send-email-longpeng2@huawei.com>
	<20161205092434.GB2498@redhat.com>
In-Reply-To: <20161205092434.GB2498@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.9 3/3] tests: crypto: add testcase
 for standard des(ecb)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: eblake@redhat.com, armbru@redhat.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org, wu.wubin@huawei.com, jianjay.zhou@huawei.com

Hi Daniel,

On 2016/12/5 17:24, Daniel P. Berrange wrote:

> On Mon, Dec 05, 2016 at 04:59:40PM +0800, Longpeng(Mike) wrote:
......
>>      {
>> +        .path = "/crypto/cipher/des-ecb",
>> +        .alg = QCRYPTO_CIPHER_ALG_DES,
>> +        .mode = QCRYPTO_CIPHER_MODE_ECB,
>> +        .key =
>> +            "0123456789abcdef",
>> +        .plaintext =
>> +            "0123456789abcde7",
>> +        .ciphertext =
>> +            "c95744256a5ed31d",
>> +    },
>> +    {
>>          .path = "/crypto/cipher/des-rfb-ecb-56",
>>          .alg = QCRYPTO_CIPHER_ALG_DES_RFB,
>>          .mode = QCRYPTO_CIPHER_MODE_ECB,
> 
> This should be included as part of the patch which adds the cipher
> in the first place. Ideally there should be a CBC mode test as well.
> 

Okay.
I will put this in the first patch(which adds the cipher) and add a cbc(aes)
testcase in v2. :)

> Regards,
> Daniel


-- 
Regards,
Longpeng(Mike)