From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35273)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <longpeng2@huawei.com>) id 1cDpwG-00016i-7y
	for qemu-devel@nongnu.org; Mon, 05 Dec 2016 04:52:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <longpeng2@huawei.com>) id 1cDpwC-0006tQ-C4
	for qemu-devel@nongnu.org; Mon, 05 Dec 2016 04:52:00 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:60919)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)
	(envelope-from <longpeng2@huawei.com>) id 1cDpwB-0006ss-Ni
	for qemu-devel@nongnu.org; Mon, 05 Dec 2016 04:51:56 -0500
Message-ID: <584538AF.8020805@huawei.com>
Date: Mon, 5 Dec 2016 17:51:43 +0800
From: "Longpeng (Mike)" <longpeng2@huawei.com>
MIME-Version: 1.0
References: <1480923846-166484-1-git-send-email-longpeng2@huawei.com>
	<1480923846-166484-2-git-send-email-longpeng2@huawei.com>
	<33183CC9F5247A488A2544077AF19020DA152B6F@DGGEMA505-MBX.china.huawei.com>
In-Reply-To: <33183CC9F5247A488A2544077AF19020DA152B6F@DGGEMA505-MBX.china.huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.9 1/2] cryptodev: fix the check of
 aes algorithm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "Wubin (H)" <wu.wubin@huawei.com>, "Zhoujian (jay, Euler)" <jianjay.zhou@huawei.com>

Hi Gonglei,

On 2016/12/5 17:34, Gonglei (Arei) wrote:

> 
......
>>
>> +#define AES_KEYSIZE_128 16
>> +#define AES_KEYSIZE_128_XTS 32
>> +#define AES_KEYSIZE_192 24
>> +#define AES_KEYSIZE_256 32
>> +#define AES_KEYSIZE_256_XTS 64
>> +
>>  static int
>> -cryptodev_builtin_get_aes_algo(uint32_t key_len, Error **errp)
>> +cryptodev_builtin_get_aes_algo(uint32_t key_len, int mode, Error **errp)
>>  {
>>      int algo;
>>
>> -    if (key_len == 128 / 8) {
>> +    if (key_len == AES_KEYSIZE_128) {
>>          algo = QCRYPTO_CIPHER_ALG_AES_128;
>> -    } else if (key_len == 192 / 8) {
>> +    } else if (key_len == AES_KEYSIZE_192) {
>>          algo = QCRYPTO_CIPHER_ALG_AES_192;
>> -    } else if (key_len == 256 / 8) {
>> -        algo = QCRYPTO_CIPHER_ALG_AES_256;
>> +    } else if (key_len == AES_KEYSIZE_256) { /* equals AES_KEYSIZE_128_XTS
>> */
> 
> So I think you can:
> 	#define AES_KEYSIZE_128_XTS  AES_KEYSIZE_256


All right,  I send a V2 later. :)

> 
> 
> Regards,
> -Gonglei
> 
......
> 


-- 
Regards,
Longpeng(Mike)