From: "Longpeng (Mike)" <longpeng2@huawei.com>
To: Eric Blake <eblake@redhat.com>
Cc: berrange@redhat.com, armbru@redhat.com, arei.gonglei@huawei.com,
qemu-devel@nongnu.org, wu.wubin@huawei.com,
jianjay.zhou@huawei.com
Subject: Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support
Date: Wed, 7 Dec 2016 08:58:06 +0800 [thread overview]
Message-ID: <58475E9E.9030704@huawei.com> (raw)
In-Reply-To: <50e11e16-6378-8ce0-241a-252272f5b99a@redhat.com>
Hi Eric,
On 2016/12/6 3:15, Eric Blake wrote:
> On 12/05/2016 02:59 AM, Longpeng(Mike) wrote:
>> This patch add standart DES support.
>
> s/standart/standard/
>
>>
>> Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
>> ---
>
>> +++ b/qapi/crypto.json
>> @@ -75,7 +75,7 @@
>> { 'enum': 'QCryptoCipherAlgorithm',
>> 'prefix': 'QCRYPTO_CIPHER_ALG',
>> 'data': ['aes-128', 'aes-192', 'aes-256',
>> - 'des-rfb',
>> + 'des-rfb', 'des',
>
> Missing documentation that includes a (since 2.9) blurb
>
Thanks, but I decide to disable standard single-DES in cryptodev, as suggested
by Daniel.
>> 'cast5-128',
>> 'serpent-128', 'serpent-192', 'serpent-256',
>> 'twofish-128', 'twofish-192', 'twofish-256']}
>>
>
--
Regards,
Longpeng(Mike)
next prev parent reply other threads:[~2016-12-07 0:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 8:59 [Qemu-devel] [PATCH for-2.9 0/3] crypto: add standard des support Longpeng(Mike)
2016-12-05 8:59 ` [Qemu-devel] [PATCH for-2.9 1/3] " Longpeng(Mike)
2016-12-05 9:18 ` Daniel P. Berrange
2016-12-05 9:29 ` Gonglei (Arei)
2016-12-05 16:59 ` Daniel P. Berrange
2016-12-06 1:23 ` Gonglei (Arei)
2016-12-06 9:21 ` Daniel P. Berrange
2016-12-06 9:28 ` Gonglei (Arei)
2016-12-05 11:11 ` Longpeng (Mike)
2016-12-05 11:18 ` Daniel P. Berrange
2016-12-05 19:15 ` Eric Blake
2016-12-07 0:58 ` Longpeng (Mike) [this message]
2016-12-05 8:59 ` [Qemu-devel] [PATCH for-2.9 2/3] cryptodev: switch to standard des Longpeng(Mike)
2016-12-05 9:25 ` Daniel P. Berrange
2016-12-05 8:59 ` [Qemu-devel] [PATCH for-2.9 3/3] tests: crypto: add testcase for standard des(ecb) Longpeng(Mike)
2016-12-05 9:24 ` Daniel P. Berrange
2016-12-05 9:46 ` Longpeng (Mike)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58475E9E.9030704@huawei.com \
--to=longpeng2@huawei.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jianjay.zhou@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).