From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/2] spice: simplify chardev setup
Date: Wed, 16 Sep 2020 11:25:31 +0200 [thread overview]
Message-ID: <5855bf1c-c705-12f2-47bf-12b76ee665ea@redhat.com> (raw)
In-Reply-To: <20200916090629.GH1535709@redhat.com>
On 16/09/20 11:06, Daniel P. Berrangé wrote:
>> + /* spice must initialize before chardevs (for spicevmc and spiceport) */
>> + qemu_spice_init();
>> +
> I don't think we should be putting this before the '-object' processing too.
> We really want -object to be the first thing processed in general.
>
What about making qemu_spice_init() idempotent (i.e. "static bool false
= true; if (!first) return; first = false;") and calling it from the
spicevmc and spiceport creation function?
Paolo
next prev parent reply other threads:[~2020-09-16 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 8:39 [PATCH v2 0/2] build spice chardevs as module Gerd Hoffmann
2020-09-16 8:39 ` [PATCH v2 1/2] spice: simplify chardev setup Gerd Hoffmann
2020-09-16 9:06 ` Daniel P. Berrangé
2020-09-16 9:25 ` Paolo Bonzini [this message]
2020-09-16 8:39 ` [PATCH v2 2/2] chardev: build spice chardevs as module Gerd Hoffmann
2020-09-16 9:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5855bf1c-c705-12f2-47bf-12b76ee665ea@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).