From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-riscv@nongnu.org,
sagark@eecs.berkeley.edu, kbastian@mail.uni-paderborn.de,
alistair@alistair23.me, mark.cave-ayland@ilande.co.uk,
sundeep.lkml@gmail.com, b.galvani@gmail.com,
nieklinnenbank@gmail.com, qemu-arm@nongnu.org,
palmer@dabbelt.com, edgar.iglesias@gmail.com
Subject: Re: [PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FIXME
Date: Wed, 15 Jul 2020 16:27:57 +0200 [thread overview]
Message-ID: <5865965e-7075-0a6d-1e75-3ce174df68b6@redhat.com> (raw)
In-Reply-To: <20200715140440.3540942-3-armbru@redhat.com>
On 15/07/2020 16.04, Markus Armbruster wrote:
> nd_table[] contains NIC configuration for boards to pick up. Device
> code has no business looking there. Several devices do it anyway.
> Two of them already have a suitable FIXME comment: "allwinner-a10" and
> "msf2-soc". Copy it to the others: "allwinner-h3", "xlnx-versal",
> "xlnx,zynqmp", "sparc32-ledma", "riscv.sifive.u.soc".
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/arm/allwinner-h3.c | 1 +
> hw/arm/xlnx-versal.c | 1 +
> hw/arm/xlnx-zynqmp.c | 1 +
> hw/dma/sparc32_dma.c | 1 +
> hw/riscv/sifive_u.c | 1 +
> 5 files changed, 5 insertions(+)
Maybe we should add an entry to
https://wiki.qemu.org/Contribute/BiteSizedTasks for this?
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-07-15 14:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 14:04 [PATCH for-5.1 0/2] Unbreak make check SPEED=slow Markus Armbruster
2020-07-15 14:04 ` [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc" Markus Armbruster
2020-07-15 14:15 ` Philippe Mathieu-Daudé
2020-07-15 14:41 ` Markus Armbruster
2020-07-16 2:59 ` sundeep subbaraya
2020-07-16 6:07 ` Thomas Huth
2020-07-16 7:36 ` Philippe Mathieu-Daudé
2020-07-16 7:54 ` sundeep subbaraya
2020-07-15 14:25 ` Thomas Huth
2020-07-15 14:39 ` Alistair Francis
2020-07-15 14:04 ` [PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FIXME Markus Armbruster
2020-07-15 14:27 ` Thomas Huth [this message]
2020-07-15 14:45 ` Markus Armbruster
2020-07-15 14:39 ` Alistair Francis
2020-07-15 16:53 ` Niek Linnenbank
2020-07-15 14:30 ` [PATCH for-5.1 0/2] Unbreak make check SPEED=slow no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5865965e-7075-0a6d-1e75-3ce174df68b6@redhat.com \
--to=thuth@redhat.com \
--cc=alistair@alistair23.me \
--cc=armbru@redhat.com \
--cc=b.galvani@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=nieklinnenbank@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
--cc=sundeep.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).