From: Li Qiang <liq3ea@gmail.com>
To: berrange@redhat.com, qemu-devel@nongnu.org
Cc: liqiang6-s@360.cn
Subject: [Qemu-devel] [PATCH] Crypto: fix leak in ivgen essiv init
Date: Tue, 3 Jan 2017 20:31:34 -0800 [thread overview]
Message-ID: <586c7aad.0834c80a.d7aff.122e@mx.google.com> (raw)
From: Li Qiang <liqiang6-s@360.cn>
On error path, the 'salt' doesn't been freed thus leading
a memory leak. This patch avoid this.
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
---
crypto/ivgen-essiv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/ivgen-essiv.c b/crypto/ivgen-essiv.c
index 634de63..cba20bd 100644
--- a/crypto/ivgen-essiv.c
+++ b/crypto/ivgen-essiv.c
@@ -48,6 +48,7 @@ static int qcrypto_ivgen_essiv_init(QCryptoIVGen *ivgen,
&salt, &nhash,
errp) < 0) {
g_free(essiv);
+ g_free(salt);
return -1;
}
--
1.8.3.1
next reply other threads:[~2017-01-04 4:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 4:31 Li Qiang [this message]
2017-01-04 10:25 ` [Qemu-devel] [PATCH] Crypto: fix leak in ivgen essiv init Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586c7aad.0834c80a.d7aff.122e@mx.google.com \
--to=liq3ea@gmail.com \
--cc=berrange@redhat.com \
--cc=liqiang6-s@360.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).