From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOdEp-0005EH-Oe for qemu-devel@nongnu.org; Tue, 03 Jan 2017 23:31:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOdEl-0005Fv-Qi for qemu-devel@nongnu.org; Tue, 03 Jan 2017 23:31:47 -0500 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:34648) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cOdEl-0005FK-NI for qemu-devel@nongnu.org; Tue, 03 Jan 2017 23:31:43 -0500 Received: by mail-qt0-x243.google.com with SMTP id j29so1640047qtc.1 for ; Tue, 03 Jan 2017 20:31:42 -0800 (PST) Message-ID: <586c7aad.0834c80a.d7aff.122e@mx.google.com> From: Li Qiang Date: Tue, 3 Jan 2017 20:31:34 -0800 Subject: [Qemu-devel] [PATCH] Crypto: fix leak in ivgen essiv init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: berrange@redhat.com, qemu-devel@nongnu.org Cc: liqiang6-s@360.cn From: Li Qiang On error path, the 'salt' doesn't been freed thus leading a memory leak. This patch avoid this. Signed-off-by: Li Qiang --- crypto/ivgen-essiv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/ivgen-essiv.c b/crypto/ivgen-essiv.c index 634de63..cba20bd 100644 --- a/crypto/ivgen-essiv.c +++ b/crypto/ivgen-essiv.c @@ -48,6 +48,7 @@ static int qcrypto_ivgen_essiv_init(QCryptoIVGen *ivgen, &salt, &nhash, errp) < 0) { g_free(essiv); + g_free(salt); return -1; } -- 1.8.3.1