From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Tom Stellard <tstellar@redhat.com>,
"P. Berrange, Daniel" <berrange@redhat.com>
Subject: Re: [PATCH 2/2] meson: Set avx512f option to auto
Date: Fri, 16 Dec 2022 15:50:10 -0800 [thread overview]
Message-ID: <5880b2c8-1c6c-f117-fab1-5c8f7846c897@linaro.org> (raw)
In-Reply-To: <CABgObfbS3BkDJ=wx38LyJJFs+__07MntKSHb2ZNUo3zo-_=Sjg@mail.gmail.com>
On 12/16/22 15:08, Paolo Bonzini wrote:
> Because that's what configure used to do
> (https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg00650.html).
> <https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg00650.html).>..
Yeah, but I wondered if that was just a bug.
> It can surely be changed but AVX512 is known to limit processor frequency. I am not sure
> if the limitation is per core or extends to multiple cores, and it would be a pity if
> guests were slowed down even further during migration.
Hmm. Should we simply remove it?
> Especially after the bulk phase buffer_is_zero performance matters a lot less so you'd pay
> the price of AVX512 for little gain. After the bulk phase it may even make sense to just
> use SSE, since even AVX requires a voltage transition[1] from what I saw at
> https://travisdowns.github.io/blog/2020/01/17/avxfreq1.html
> <https://travisdowns.github.io/blog/2020/01/17/avxfreq1.html>.
Ouch, never heard of that.
I'm not going to worry about it, because glibc str* routines make the same choice to use
AVX2, as does TCG, so I can only imagine that for the most part we're continually in and
out of 256-bit avx mode.
Anyway, I'll drop this patch.
r~
next prev parent reply other threads:[~2022-12-16 23:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 1:51 [PATCH v2 0/2] Use a more portable way to enable target specific functions Richard Henderson
2022-12-04 1:51 ` [PATCH 1/2] util/bufferiszero: Use __attribute__((target)) for avx2/avx512 Richard Henderson
2022-12-05 11:17 ` Daniel P. Berrangé
2022-12-05 15:16 ` Richard Henderson
2022-12-04 1:51 ` [PATCH 2/2] meson: Set avx512f option to auto Richard Henderson
2022-12-16 20:47 ` Richard Henderson
2022-12-16 23:08 ` Paolo Bonzini
2022-12-16 23:50 ` Richard Henderson [this message]
2022-12-19 10:21 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5880b2c8-1c6c-f117-fab1-5c8f7846c897@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tstellar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).