From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDB6A-0007SC-G1 for qemu-devel@nongnu.org; Wed, 06 Mar 2013 04:57:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDB69-0002B3-Fj for qemu-devel@nongnu.org; Wed, 06 Mar 2013 04:57:22 -0500 Received: from mx4-phx2.redhat.com ([209.132.183.25]:56314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDB69-0002Aw-75 for qemu-devel@nongnu.org; Wed, 06 Mar 2013 04:57:21 -0500 Date: Wed, 6 Mar 2013 04:57:19 -0500 (EST) From: Paolo Bonzini Message-ID: <589499047.3116990.1362563839222.JavaMail.root@redhat.com> In-Reply-To: <51369173.5060808@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com > On 03/06/13 00:37, Eric Blake wrote: > > > I guess I had in my mind %c instead of %u; still, I can't help but > > wonder if fprintf() and buffering is overkill, compared to just > > doing > > something like this: > > write(fd, &"01"[vcpu->online], 1); > > > > (okay, I hope you would favor readability over my compact > > representation, but you get the point). > > I'd be crucified on qemu-devel if I tried to pull off something like > the above :) I think stdio is just fine... Paolo