From: Gonglei <arei.gonglei@huawei.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear()
Date: Mon, 6 Feb 2017 11:36:50 +0800 [thread overview]
Message-ID: <5897EF52.5030709@huawei.com> (raw)
In-Reply-To: <1486146260-8092-1-git-send-email-peter.maydell@linaro.org>
On 2017/2/4 2:24, Peter Maydell wrote:
> The functions vnc_has_job() and vnc_jobs_clear() are
> never used; remove them.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>
> I last had a go at this five years ago:
> http://patchwork.ozlabs.org/patch/192335/
>
> Since then vnc_stop_worker_thread() got removed anyway in
> commit 09526058d, but the vnc_jobs_clear() function that
> it was the only caller of got left behind.
>
> vnc_has_job() has never been used by anybody, and it's
> impossible to use in a non-racy way, so drop it too.
>
> ui/vnc-jobs.h | 2 --
> ui/vnc-jobs.c | 23 -----------------------
> 2 files changed, 25 deletions(-)
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
next prev parent reply other threads:[~2017-02-06 3:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 18:24 [Qemu-devel] [PATCH] ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear() Peter Maydell
2017-02-06 3:36 ` Gonglei [this message]
2017-02-06 12:47 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5897EF52.5030709@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=kraxel@redhat.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).