* [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing iso td
@ 2017-02-07 11:15 Li Qiang
2017-02-15 6:25 ` Li Qiang
0 siblings, 1 reply; 2+ messages in thread
From: Li Qiang @ 2017-02-07 11:15 UTC (permalink / raw)
To: kraxel, qemu-devel; +Cc: Li Qiang
From: Li Qiang <liqiang6-s@360.cn>
It should return 1 if an error occurs when reading iso td.
This will avoid an infinite loop issue in ohci_service_ed_list.
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
---
hw/usb/hcd-ohci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 4a63f3b..21c93e0 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -727,7 +727,7 @@ static int ohci_service_iso_td(OHCIState *ohci, struct ohci_ed *ed,
if (ohci_read_iso_td(ohci, addr, &iso_td)) {
trace_usb_ohci_iso_td_read_failed(addr);
ohci_die(ohci);
- return 0;
+ return 1;
}
starting_frame = OHCI_BM(iso_td.flags, TD_SF);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing iso td
2017-02-07 11:15 [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing iso td Li Qiang
@ 2017-02-15 6:25 ` Li Qiang
0 siblings, 0 replies; 2+ messages in thread
From: Li Qiang @ 2017-02-15 6:25 UTC (permalink / raw)
To: Gerd Hoffmann, Qemu Developers; +Cc: Li Qiang
Ping...
2017-02-07 19:15 GMT+08:00 Li Qiang <liq3ea@gmail.com>:
> From: Li Qiang <liqiang6-s@360.cn>
>
> It should return 1 if an error occurs when reading iso td.
> This will avoid an infinite loop issue in ohci_service_ed_list.
>
> Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> ---
> hw/usb/hcd-ohci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
> index 4a63f3b..21c93e0 100644
> --- a/hw/usb/hcd-ohci.c
> +++ b/hw/usb/hcd-ohci.c
> @@ -727,7 +727,7 @@ static int ohci_service_iso_td(OHCIState *ohci, struct
> ohci_ed *ed,
> if (ohci_read_iso_td(ohci, addr, &iso_td)) {
> trace_usb_ohci_iso_td_read_failed(addr);
> ohci_die(ohci);
> - return 0;
> + return 1;
> }
>
> starting_frame = OHCI_BM(iso_td.flags, TD_SF);
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-15 6:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-07 11:15 [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing iso td Li Qiang
2017-02-15 6:25 ` Li Qiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).