From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB
Date: Thu, 8 Jul 2021 09:17:34 -0700 [thread overview]
Message-ID: <589d27e5-58e5-6af2-dfd8-11130fdbc2d9@linaro.org> (raw)
In-Reply-To: <CAFEAcA8Xs0Ct6hDBAk-N7TVhb66dwv2EJudo83XzJ5dQn9k7VA@mail.gmail.com>
On 7/8/21 9:11 AM, Peter Maydell wrote:
>>> Why isn't it enough here just to set is_jmp to DISAS_NEXT ?
>>
>> You mean DISAS_TOO_MANY? That would work, yes.
>> At the time I was just thinking of replacing one jump with another.
>
> You've implicitly answered my question, which is that the main
> translator loop code treats DISAS_NEXT as "keep adding insns to
> the TB" :-)
>
> It feels slightly like misuse to use DISAS_TOO_MANY, unless we
> renamed it to something like DISAS_END_TB (which is what it's
> actually doing).
Yeah, better naming would have been a good. In this instance I think I chose an odd
colour for the bike shed.
The problem with just DISAS_END_TB is that there are many ways to end a tb, with at least:
(1) goto_tb next, (2) goto_ptr next, (3) exit_tb. We wind up replicating these three
across many of the targets, so it would be a really nice cleanup to standardize, and with
good names.
r~
next prev parent reply other threads:[~2021-07-08 17:09 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 18:31 [PATCH v2 00/28] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
2021-06-30 18:31 ` [PATCH v2 01/28] " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 02/28] target/alpha: Remove use_exit_tb Richard Henderson
2021-07-08 12:34 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 03/28] target/alpha: Remove in_superpage Richard Henderson
2021-07-08 12:35 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 04/28] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:29 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB Richard Henderson
2021-07-08 12:05 ` Peter Maydell
2021-07-08 16:04 ` Richard Henderson
2021-07-08 16:11 ` Peter Maydell
2021-07-08 16:17 ` Richard Henderson [this message]
2021-07-08 17:47 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 06/28] target/arm: Use translator_use_goto_tb for aarch64 Richard Henderson
2021-07-08 12:08 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 07/28] target/arm: Use translator_use_goto_tb for aarch32 Richard Henderson
2021-07-08 12:14 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 08/28] target/avr: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:28 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 09/28] target/avr: Mark some helpers noreturn Richard Henderson
2021-06-30 18:32 ` [PATCH v2 10/28] target/cris: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:27 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 11/28] target/hppa: " Richard Henderson
2021-07-08 12:26 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 12/28] target/i386: " Richard Henderson
2021-07-08 12:26 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 13/28] target/m68k: " Richard Henderson
2021-07-08 12:22 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 14/28] target/microblaze: " Richard Henderson
2021-07-08 12:21 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 15/28] target/mips: " Richard Henderson
2021-07-08 12:18 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 16/28] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-06-30 18:32 ` [PATCH v2 17/28] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:17 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 18/28] target/openrisc: " Richard Henderson
2021-07-07 20:59 ` Stafford Horne
2021-06-30 18:32 ` [PATCH v2 19/28] target/ppc: " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 20/28] target/riscv: " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 21/28] target/rx: " Richard Henderson
2021-07-08 12:17 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 22/28] target/s390x: " Richard Henderson
2021-07-01 7:42 ` David Hildenbrand
2021-06-30 18:32 ` [PATCH v2 23/28] target/s390x: Remove use_exit_tb Richard Henderson
2021-07-01 7:44 ` David Hildenbrand
2021-06-30 18:32 ` [PATCH v2 24/28] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:16 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 25/28] target/sparc: " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 26/28] target/tricore: " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-06-30 18:32 ` [PATCH v2 28/28] target/xtensa: Use translator_use_goto_tb Richard Henderson
2021-07-07 21:41 ` [PATCH v2 00/28] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=589d27e5-58e5-6af2-dfd8-11130fdbc2d9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).