From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cghoA-0008J6-2d for qemu-devel@nongnu.org; Wed, 22 Feb 2017 20:02:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgho5-0005ge-T5 for qemu-devel@nongnu.org; Wed, 22 Feb 2017 20:02:58 -0500 Received: from [45.249.212.189] (port=2403 helo=dggrg03-dlp.huawei.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1cgho5-0005Vn-9Z for qemu-devel@nongnu.org; Wed, 22 Feb 2017 20:02:53 -0500 References: <1487734936-43472-1-git-send-email-zhang.zhanghailiang@huawei.com> <1487734936-43472-3-git-send-email-zhang.zhanghailiang@huawei.com> <134776c2-a85d-d06f-5f98-2e664f9c8ca9@cn.fujitsu.com> From: Hailiang Zhang Message-ID: <58AE349E.2020704@huawei.com> Date: Thu, 23 Feb 2017 09:02:22 +0800 MIME-Version: 1.0 In-Reply-To: <134776c2-a85d-d06f-5f98-2e664f9c8ca9@cn.fujitsu.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/15] colo-compare: implement the process of checkpoint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen , qemu-devel@nongnu.org, Jason Wang Cc: xuquan8@huawei.com, dgilbert@redhat.com, lizhijian@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com Hi, On 2017/2/22 17:31, Zhang Chen wrote: > > > On 02/22/2017 11:42 AM, zhanghailiang wrote: >> While do checkpoint, we need to flush all the unhandled packets, >> By using the filter notifier mechanism, we can easily to notify >> every compare object to do this process, which runs inside >> of compare threads as a coroutine. > > Hi~ Jason and Hailiang. > > I will send a patch set later about colo-compare notify mechanism for > Xen like this patch. > I want to add a new chardev socket way in colo-comapre connect to Xen > colo, for notify > checkpoint or failover, Because We have no choice to use this way > communicate with Xen codes. > That's means we will have two notify mechanism. > What do you think about this? > I don't think you need another mechanism, what you need to do is to realize a qmp command which calls colo_notify_compares_event(), It will not return until the event (checkpoint or failover) be handled by all compares. Will this satisfy your requirement ? Thanks, Hailiang > > Thanks > Zhang Chen > >> >> Cc: Jason Wang >> Signed-off-by: zhanghailiang >> Signed-off-by: Zhang Chen >> --- >> net/colo-compare.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> net/colo-compare.h | 20 +++++++++++++++ >> 2 files changed, 92 insertions(+) >> create mode 100644 net/colo-compare.h >> >