From: "Longpeng (Mike)" <longpeng2@huawei.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: xuquan8@huawei.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.10 15/19] tests: crypto: add cipher speed case
Date: Mon, 10 Apr 2017 18:25:34 +0800 [thread overview]
Message-ID: <58EB5D9E.3040504@huawei.com> (raw)
In-Reply-To: <20170410095133.GC3655@redhat.com>
Hi Daniel,
Ok, I'll take all your suggestions, and fix them in next version.
Thanks.
On 2017/4/10 17:51, Daniel P. Berrange wrote:
> On Mon, Apr 10, 2017 at 05:00:58PM +0800, Longpeng(Mike) wrote:
>> Now we have afalg-backend and libiary-backend, it's necessary
>> to add the speed test in test-crypto-cipher.
>>
>> We can use "./tests/test-crypto-cipher speed" to do the speed
>> test.
>
> This is not using any of the existing code for the benchmark, so there's
> no real benefit to having it in this file.
>
> I'd suggest creating a separate test program for performance benchmarking,
> eg tests/benchmark-crypto-cipher, that would be invoked separately as &
> when needed ie skipped by make check-unit, but run by a 'make check-speed'.
>
> Likewise for the other tests you've changed later in this series.
>
>
> Regards,
> Daniel
--
Regards,
Longpeng(Mike)
prev parent reply other threads:[~2017-04-10 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 9:00 [Qemu-devel] [PATCH for-2.10 15/19] tests: crypto: add cipher speed case Longpeng(Mike)
2017-04-10 9:51 ` Daniel P. Berrange
2017-04-10 10:25 ` Longpeng (Mike) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58EB5D9E.3040504@huawei.com \
--to=longpeng2@huawei.com \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xuquan8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).