From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu-config: never call the callback after an error, fix leak
Date: Thu, 8 Jul 2021 13:40:35 +0200 [thread overview]
Message-ID: <58b1152f-edd9-c533-b991-b873947a388c@redhat.com> (raw)
In-Reply-To: <87eec99mzk.fsf@dusky.pond.sub.org>
On 08/07/21 11:24, Markus Armbruster wrote:
> Looks like the patch fixes two separate issues:
>
> 1. Memory leak on ferror()
> Fixes: f7544edcd32e602af1aae86714dc7c32350d5d7c
>
> 2. Callback can run on error.
> Fixes: 37701411397c7b7d709ae92abd347cc593940ee5
>
> I*think* this happens when the cb() further up fails, and when a
> line following the [...] section header cannot be parsed.
>
> Worth fixing the separate bugs in separate patches?
Yes, good idea.
Paolo
prev parent reply other threads:[~2021-07-08 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 12:15 [PATCH] qemu-config: never call the callback after an error, fix leak Paolo Bonzini
2021-07-08 9:24 ` Markus Armbruster
2021-07-08 11:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b1152f-edd9-c533-b991-b873947a388c@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).