From: Richard Henderson <richard.henderson@linaro.org>
To: Alexey Baturo <baturo.alexey@gmail.com>
Cc: qemu-riscv@nongnu.org, sagark@eecs.berkeley.edu,
kbastian@mail.uni-paderborn.de, qemu-devel@nongnu.org,
space.monkey.delivers@gmail.com, Alistair.Francis@wdc.com,
kupokupokupopo@gmail.com, palmer@dabbelt.com
Subject: Re: [PATCH v7 4/6] [RISCV_PM] Support pointer masking for RISC-V for i/c/f/d/a types of instructions
Date: Thu, 21 Jan 2021 09:42:14 -1000 [thread overview]
Message-ID: <58c2088b-10f4-2f39-bc6f-50457ed45788@linaro.org> (raw)
In-Reply-To: <20210110185109.29841-5-space.monkey.delivers@gmail.com>
On 1/10/21 8:51 AM, Alexey Baturo wrote:
> Signed-off-by: Alexey Baturo <space.monkey.delivers@gmail.com>
> ---
> target/riscv/insn_trans/trans_rva.c.inc | 3 +++
> target/riscv/insn_trans/trans_rvd.c.inc | 2 ++
> target/riscv/insn_trans/trans_rvf.c.inc | 2 ++
> target/riscv/insn_trans/trans_rvi.c.inc | 2 ++
> target/riscv/translate.c | 14 ++++++++++++++
> 5 files changed, 23 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> +static void gen_pm_adjust_address(DisasContext *s,
> + TCGv_i64 dst,
> + TCGv_i64 src)
Don't bother aligning variables like this. That just leads to additional
changes when code is adjusted later.
r~
next prev parent reply other threads:[~2021-01-21 19:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 18:51 [PATCH v7 0/6] RISC-V Pointer Masking implementation Alexey Baturo
2021-01-10 18:51 ` [PATCH v7 1/6] [RISCV_PM] Add J-extension into RISC-V Alexey Baturo
2021-01-15 22:08 ` Alistair Francis
2021-01-10 18:51 ` [PATCH v7 2/6] [RISCV_PM] Support CSRs required for RISC-V PM extension except for the ones required for hypervisor mode Alexey Baturo
2021-02-03 19:19 ` Alistair Francis
2021-01-10 18:51 ` [PATCH v7 3/6] [RISCV_PM] Print new PM CSRs in QEMU logs Alexey Baturo
2021-01-15 22:09 ` Alistair Francis
2021-01-10 18:51 ` [PATCH v7 4/6] [RISCV_PM] Support pointer masking for RISC-V for i/c/f/d/a types of instructions Alexey Baturo
2021-01-21 19:42 ` Richard Henderson [this message]
2021-02-03 19:20 ` Alistair Francis
2021-01-10 18:51 ` [PATCH v7 5/6] [RISCV_PM] Implement address masking functions required for RISC-V Pointer Masking extension Alexey Baturo
2021-02-03 19:27 ` Alistair Francis
2021-01-10 18:51 ` [PATCH v7 6/6] [RISCV_PM] Allow experimental J-ext to be turned on Alexey Baturo
2021-01-15 22:10 ` Alistair Francis
2021-01-21 19:45 ` Richard Henderson
2021-02-03 19:22 ` [PATCH v7 0/6] RISC-V Pointer Masking implementation Alistair Francis
2021-02-15 20:52 ` Alexey Baturo
2021-02-16 0:01 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58c2088b-10f4-2f39-bc6f-50457ed45788@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=baturo.alexey@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kupokupokupopo@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
--cc=space.monkey.delivers@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).