From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B10B0C27C6E for ; Mon, 17 Jun 2024 09:33:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJ8jK-0003p6-1H; Mon, 17 Jun 2024 05:32:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJ8jG-0003oc-Gl for qemu-devel@nongnu.org; Mon, 17 Jun 2024 05:32:46 -0400 Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJ8jD-00006k-2E for qemu-devel@nongnu.org; Mon, 17 Jun 2024 05:32:46 -0400 Received: from loongson.cn (unknown [10.20.42.239]) by gateway (Coremail) with SMTP id _____8CxOuq2AnBmmYcHAA--.29771S3; Mon, 17 Jun 2024 17:32:38 +0800 (CST) Received: from [10.20.42.239] (unknown [10.20.42.239]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxhsW0AnBmwVglAA--.14046S3; Mon, 17 Jun 2024 17:32:38 +0800 (CST) Subject: Re: [PATCH 06/18] tcg/loongarch64: Simplify tcg_out_dup_vec To: Richard Henderson , qemu-devel@nongnu.org Cc: git@xen0n.name References: <20240527211912.14060-1-richard.henderson@linaro.org> <20240527211912.14060-7-richard.henderson@linaro.org> From: gaosong Message-ID: <58cb5a62-df59-8c69-a2e4-1bddd187dbb6@loongson.cn> Date: Mon, 17 Jun 2024 17:32:39 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20240527211912.14060-7-richard.henderson@linaro.org> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf8AxhsW0AnBmwVglAA--.14046S3 X-CM-SenderInfo: 5jdr20tqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoW7WFWDKr1fJFy5trW5uw45Jwc_yoW8Gr1kpw nI9F1UJF4rJa1kCFZIvayUKryIqw4ru34aya43Kw1kWrsxZa4UXw4rGr1aqryay3s29r10 v3ZYvrnxuFWqy3XCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvIb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv 67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF 1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r 4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jY 38nUUUUU= Received-SPF: pass client-ip=114.242.206.163; envelope-from=gaosong@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, MIME_CHARSET_FARAWAY=2.45, NICE_REPLY_A=-2.677, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org ÔÚ 2024/5/28 ÉÏÎç5:19, Richard Henderson дµÀ: > Signed-off-by: Richard Henderson > --- > tcg/loongarch64/tcg-target.c.inc | 22 ++++++---------------- > 1 file changed, 6 insertions(+), 16 deletions(-) Reviewed-by: Song Gao Thanks. Song Gao > diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc > index 980ea10211..b1d652355d 100644 > --- a/tcg/loongarch64/tcg-target.c.inc > +++ b/tcg/loongarch64/tcg-target.c.inc > @@ -1674,22 +1674,12 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, > static bool tcg_out_dup_vec(TCGContext *s, TCGType type, unsigned vece, > TCGReg rd, TCGReg rs) > { > - switch (vece) { > - case MO_8: > - tcg_out_opc_vreplgr2vr_b(s, rd, rs); > - break; > - case MO_16: > - tcg_out_opc_vreplgr2vr_h(s, rd, rs); > - break; > - case MO_32: > - tcg_out_opc_vreplgr2vr_w(s, rd, rs); > - break; > - case MO_64: > - tcg_out_opc_vreplgr2vr_d(s, rd, rs); > - break; > - default: > - g_assert_not_reached(); > - } > + static const LoongArchInsn repl_insn[4] = { > + OPC_VREPLGR2VR_B, OPC_VREPLGR2VR_H, OPC_VREPLGR2VR_W, OPC_VREPLGR2VR_D > + }; > + > + tcg_debug_assert(vece <= MO_64); > + tcg_out32(s, encode_vdj_insn(repl_insn[vece], rd, rs)); > return true; > } >